[quicwg/base-drafts] DUPLICATE_PUSH push ID validation (#2681)

Lucas Pardue <notifications@github.com> Thu, 09 May 2019 16:16 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CFD20120112 for <quic-issues@ietfa.amsl.com>; Thu, 9 May 2019 09:16:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.464
X-Spam-Level:
X-Spam-Status: No, score=-6.464 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tIaORj1OJikg for <quic-issues@ietfa.amsl.com>; Thu, 9 May 2019 09:16:48 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CABD412006B for <quic-issues@ietf.org>; Thu, 9 May 2019 09:16:47 -0700 (PDT)
Date: Thu, 09 May 2019 09:16:46 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557418606; bh=301joYjDqyA9BfdBZpLjnHvC/hg9k6EGsaRGs8ospzc=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=SNA1lLKfYhptDzYnxFcoMvoao8CG0wJw8s8EUOSZShA9jIEAoAC7w2B9TWs1z4slC NmWXOTjdqHvIp+iqqXniymFq1fQVn+i9aAM70xVcuhREYMqIfC/RsXKVyvQjm4MrqU 4kj8hW+K5Op0mWv3JTdyDht+pQWNbnbA7jfcb9h4=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4ERYGQTKEPO57QX4F24GCO5EVBNHHBUXKDQA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2681@github.com>
Subject: [quicwg/base-drafts] DUPLICATE_PUSH push ID validation (#2681)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd4526ea4a5d_31313fb3cd0cd96847848"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8PXevMbUNtmsjfG20lPISbsHrnY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 09 May 2019 16:16:50 -0000

Two questions: 
1. Should DUPLICATE_PUSH respect max push ID limit?
  PUSH_PROMISE says the following:

 > A server MUST NOT use a Push ID that is larger than the client has
   provided in a MAX_PUSH_ID frame (Section 4.2.8) and MUST NOT use the
   same Push ID in multiple PUSH_PROMISE frames

2. What should a client do if it sees a DUPLICATE_PUSH for an ID of a PUSH_PROMISE that it never received?

This could be caused by a race condition, so it seems sensible to allow this to clients to support this without error. We should probably document that like we did for other racy things.
It 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2681