Re: [quicwg/base-drafts] ACK and PADDING (#1713)
ianswett <notifications@github.com> Tue, 28 August 2018 23:17 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 70A5B124BE5 for <quic-issues@ietfa.amsl.com>; Tue, 28 Aug 2018 16:17:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o-UBM2AGOFd6 for <quic-issues@ietfa.amsl.com>; Tue, 28 Aug 2018 16:17:44 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E0CE612426A for <quic-issues@ietf.org>; Tue, 28 Aug 2018 16:17:43 -0700 (PDT)
Date: Tue, 28 Aug 2018 16:17:42 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1535498262; bh=50qzxxiCcJqTLV/QNKiBoHV+BEJ3pCXHrZqfAOKb/xk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=PUMIsOf6B282gBnyKxomgpLOwSG2/yk7EH0lSCNtm+X9f5304z4nDxgRAvmDJz3eD tCozDyWbF1CkmD/uzFuqfRiuI2rvx8gjfBVQCm6EAxcpLht014NGsdr7K3u9UQ/d1x 3r4TuGLblUgK6Vbneu2NK7vnbMkeUdR/QKMOLyxw=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab88bb8ec9a032ce083ffce6ea6a6316c392d6db7c92cf00000001179d9a1692a169ce1527d0a4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1713/review/150352674@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1713@github.com>
References: <quicwg/base-drafts/pull/1713@github.com>
Subject: Re: [quicwg/base-drafts] ACK and PADDING (#1713)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b85d816cc1d3_5c803fafa7ed45b893729"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8UJmc6IetlCwZ1B-8cBZH6zYhDU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Aug 2018 23:17:45 -0000
ianswett commented on this pull request. > @@ -3418,14 +3418,15 @@ ACK Block (repeated): ### Sending ACK Frames Implementations MUST NOT generate packets that only contain ACK frames in -response to packets which only contain ACK frames. However, they MUST -acknowledge packets containing only ACK frames when sending ACK frames in -response to other packets. Implementations MUST NOT send more than one packet -containing only an ACK frame per received packet that contains frames other than -an ACK frame. Packets containing non-ACK frames MUST be acknowledged -immediately or when a delayed ack timer expires. The delayed ack timer MUST -NOT delay an ACK for longer than an RTT, which ensures an ACK frame is sent -at least once per RTT if new packets needing acknowledgement were received. +response to packets which only contain ACK and PADDING frames. However, they +MUST acknowledge packets containing only ACK and PADDING frames when sending +ACK frames in response to other packets. Implementations MUST NOT send more +than one packet containing only an ACK frame per received packet that contains To clarify, are you saying I should replace "ACK and PADDING" with "ACK or PADDING" everywhere or another suggestion? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1713#discussion_r213502265
- [quicwg/base-drafts] ACK and PADDING (#1713) ianswett
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) Martin Thomson
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) Martin Thomson
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) ianswett
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) Martin Thomson
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) Christian Huitema
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) MikkelFJ
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) ianswett
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) Martin Thomson
- Re: [quicwg/base-drafts] ACK and PADDING (#1713) Martin Thomson