IETF Logo Mail Archive

Re: [quicwg/base-drafts] TP to disable migration (#1447)

Rui Paulo <notifications@github.com> Fri, 22 June 2018 17:26 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AE3BB130EB3 for <quic-issues@ietfa.amsl.com>; Fri, 22 Jun 2018 10:26:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1hBpK_5_QQ9a for <quic-issues@ietfa.amsl.com>; Fri, 22 Jun 2018 10:26:57 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 074C8130E10 for <quic-issues@ietf.org>; Fri, 22 Jun 2018 10:26:57 -0700 (PDT)
Date: Fri, 22 Jun 2018 10:26:56 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1529688416; bh=enOCHeAihGjU4h6CRzwnCqHNR0WiQk7KLFA7NZkned4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=VUQe58Qfl1xZjyeNr9SBV/UjPF5W7VO+kcFgIcJYchJe1/ZC55sX1nyfm3GiA35X1 MGKubsNOkGLnofk6xhznkyIPTLI1N0ppKkSZCVT1iiffJCg8m3SIaJqVaTP31lxULY 3fLsXI0iYZXy+6MXRgO1cngYdoIhjfCO0PQyb7xY=
From: Rui Paulo <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5478bc189a271d2adcf132fee69ebc3b775175ed92cf000000011744f36092a169ce13d3250f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1447/review/131279954@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1447@github.com>
References: <quicwg/base-drafts/pull/1447@github.com>
Subject: Re: [quicwg/base-drafts] TP to disable migration (#1447)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b2d316022b15_67802aed6f96cf5821898"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: rpaulo
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8YHaZl-hS0tN3pOonHYwttpdtiI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jun 2018 17:26:59 -0000

rpaulo commented on this pull request.



> @@ -1656,7 +1664,12 @@ network.  This section describes the process by which an endpoint migrates to a
 new address.
 
 An endpoint MUST NOT initiate connection migration before the handshake is
-finished and the endpoint has 1-RTT keys.
+finished and the endpoint has 1-RTT keys.  An endpoint also MUST NOT initiate
+connection migration if the peer sent the `disable_migration` transport
+parameter during the handshake.  An endpoint which has sent this transport
+parameter, but detects that a peer has nonetheless migrated to a different
+network MAY treat this as a connection error of type INVALID_MIGRATION.
+However, note that not all changes of peer address are intentional migrations.

I really think we should mention NAT rebinding here and how `disable_migration` doesn't mean the endpoint doesn't need to handle NAT rebinding.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1447#pullrequestreview-131279954

v2.23.0 | Report a Bug | By Email