Re: [quicwg/base-drafts] ACK frames PN space editorial (#3313)

Martin Thomson <notifications@github.com> Thu, 02 January 2020 03:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 21FC312004C for <quic-issues@ietfa.amsl.com>; Wed, 1 Jan 2020 19:02:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7Eudey0k9rEt for <quic-issues@ietfa.amsl.com>; Wed, 1 Jan 2020 19:02:45 -0800 (PST)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6647F120046 for <quic-issues@ietf.org>; Wed, 1 Jan 2020 19:02:45 -0800 (PST)
Received: from github-lowworker-9bcb4a1.ac4-iad.github.net (github-lowworker-9bcb4a1.ac4-iad.github.net [10.52.25.84]) by smtp.github.com (Postfix) with ESMTP id B20E0520AA4 for <quic-issues@ietf.org>; Wed, 1 Jan 2020 19:02:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1577934164; bh=abCeeuew0dtZYoNqXmjTWomvJ0LnE7QBatuM6eoiIe8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=vDYiYXXn+LwqA0TTmH6z6dsaPM0A82Lv64it8uOjYhd1LM1Tn7l/4AmSr39xnsxCV 1wCQB34jk+mPzODZCgHNADxebuVoJFJUi4K4Nh+Xztg//ijparnezHG2R4CP/T87ei EoSf3FTT3mQynXEsvEuAtYCw2Ch78vPnJrlL5GNA=
Date: Wed, 01 Jan 2020 19:02:44 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYVAMCG6Z6BZPBQX5F4DKH5JEVBNHHCA3E5IY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3313/review/337521597@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3313@github.com>
References: <quicwg/base-drafts/pull/3313@github.com>
Subject: Re: [quicwg/base-drafts] ACK frames PN space editorial (#3313)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e0d5d54a39ab_1c473f9a74ccd960701e2"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8fNecsoC1aGMY4LYYBvk74Ied9g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jan 2020 03:02:47 -0000

martinthomson commented on this pull request.

This is better than #3314, I think, though I have a suggestion here.

> @@ -4747,10 +4747,9 @@ QUIC acknowledgements are irrevocable.  Once acknowledged, a packet remains
 acknowledged, even if it does not appear in a future ACK frame.  This is unlike
 TCP SACKs ({{?RFC2018}}).
 
-It is expected that a sender will reuse the same packet number across different
-packet number spaces.  ACK frames only acknowledge the packet numbers that were
-transmitted by the sender in the same packet number space of the packet that the
-ACK was received in.
+An ACK frame acknowledges packets in the same packet number space as the packet
+in which it is contained.  As such, the same packet number can be acknowledged

```suggestion
in which it is contained.  Packets from different packet number spaces can be identified using the same numeric value.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3313#pullrequestreview-337521597