IETF Logo Mail Archive

Re: [quicwg/base-drafts] Define AreAllPacketsLost() (#3290)

Alessandro Ghedini <notifications@github.com> Fri, 06 December 2019 17:59 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 38AB8120086 for <quic-issues@ietfa.amsl.com>; Fri, 6 Dec 2019 09:59:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id opVGtedWFAkD for <quic-issues@ietfa.amsl.com>; Fri, 6 Dec 2019 09:59:51 -0800 (PST)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7A9DD120132 for <quic-issues@ietf.org>; Fri, 6 Dec 2019 09:59:44 -0800 (PST)
Received: from github-lowworker-2e54e43.va3-iad.github.net (github-lowworker-2e54e43.va3-iad.github.net [10.48.17.27]) by smtp.github.com (Postfix) with ESMTP id CE9328C0E2C for <quic-issues@ietf.org>; Fri, 6 Dec 2019 09:59:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1575655183; bh=Q55eAc72GNTm8niTDdLsXP+g+8x0d60CxiF4uUqjR30=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Qv0e/asiHc9Fm/hOdoTOOVuteTNe7dxzVVSMw8ZhLISmeK8ujzA4mgtbptglz3knU x/61nijlyU40vztyRw0W0GAYKpfCJVxdCsERuT+wnOsBY9um10CfZCMJ5WvCXjTQNT HsRojPmyzD5/GXlnY3+56T1aZL4DsiEWYsqWWd/c=
Date: Fri, 06 Dec 2019 09:59:43 -0800
From: Alessandro Ghedini <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3ASFQB77XSLVVND3V367EY7EVBNHHB7VVU2M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3290/review/328364730@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3290@github.com>
References: <quicwg/base-drafts/pull/3290@github.com>
Subject: Re: [quicwg/base-drafts] Define AreAllPacketsLost() (#3290)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dea970fbf1bc_166d3ffdbdecd95c7525d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ghedo
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8nSycfUYxHoVMGj06DZLk7J0Nrc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Dec 2019 17:59:53 -0000

ghedo commented on this pull request.



> @@ -1407,15 +1409,23 @@ Invoked when an ACK frame with an ECN section is received from the peer.
 Invoked from DetectLostPackets when packets are deemed lost.
 
 ~~~
-   InPersistentCongestion(largest_lost_packet):
+   InPersistentCongestion(lost_packets):

I think this is already checked before calling `OnPacketsLost()`?
```
  if (!lost_packets.empty()):
    OnPacketsLost(lost_packets)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3290#discussion_r354958934

v2.23.0 | Report a Bug | By Email