Re: [quicwg/base-drafts] Attempt to define slow start/congestion avoidance (#4005)

Jana Iyengar <notifications@github.com> Tue, 25 August 2020 01:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9401B3A0EDE for <quic-issues@ietfa.amsl.com>; Mon, 24 Aug 2020 18:23:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.475
X-Spam-Level:
X-Spam-Status: No, score=-0.475 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=0.726, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bUnSRdC7j01J for <quic-issues@ietfa.amsl.com>; Mon, 24 Aug 2020 18:23:18 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0B2C13A0EDD for <quic-issues@ietf.org>; Mon, 24 Aug 2020 18:23:17 -0700 (PDT)
Received: from github-lowworker-292e294.va3-iad.github.net (github-lowworker-292e294.va3-iad.github.net [10.48.102.70]) by smtp.github.com (Postfix) with ESMTP id 27B93600DB9 for <quic-issues@ietf.org>; Mon, 24 Aug 2020 18:23:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1598318597; bh=afuGp1dAt4WqoBs0gyYj4BCsUVbftFM/v6at966akxQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wTUV69KGQkO9sm1hmszh2xF/1NNtaNkePpfaHdkg6Sc1lE8gAw/WUmVDsP0BU1uxQ dHV7AORQYSJkRI71i6HfF3ij6taIYf5zWmjRs6oLt0vgAgbML2zlHkggR8a5qC79Ce VAHaZDxcU5GaNrtr+yvWh5JpRe0EgA1//GBR7hyU=
Date: Mon, 24 Aug 2020 18:23:17 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2UMPXEADXVA5L7ZFF5KBEQLEVBNHHCRBYB7A@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4005/review/474030278@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4005@github.com>
References: <quicwg/base-drafts/pull/4005@github.com>
Subject: Re: [quicwg/base-drafts] Attempt to define slow start/congestion avoidance (#4005)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f44680517ee7_1e7919642287d2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8nX_QcCEBCOgoJsHH7guQYIwBGo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Aug 2020 01:23:20 -0000

@janaiyengar commented on this pull request.



> +When first entering congestion avoidance, when a packet is declared lost, or
+when the ECN-CE count is increased, the congestion controller described in this
+document halves the congestion window, reduces the slow start threshold to the
+resulting size, and enters the recovery period. A congestion controller MUST
+reduce the congestion window when a loss or ECN-CE marking is detected.

```suggestion
When first entering congestion avoidance, when a packet is declared lost, or
when the ECN-CE count is increased, the congestion controller described in this
document MUST halve the congestion window, set the slow start threshold to the
size of the reduced congestion window, and enter the recovery period.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4005#pullrequestreview-474030278