Re: [quicwg/base-drafts] Mandate allowing peer to create enough unidirectional streams for HTTP and QPACK (#2762)

Kazuho Oku <notifications@github.com> Mon, 03 June 2019 05:31 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 04619120116 for <quic-issues@ietfa.amsl.com>; Sun, 2 Jun 2019 22:31:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NvKMSqGTgGpH for <quic-issues@ietfa.amsl.com>; Sun, 2 Jun 2019 22:31:06 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BC2DC12012C for <quic-issues@ietf.org>; Sun, 2 Jun 2019 22:31:06 -0700 (PDT)
Date: Sun, 02 Jun 2019 22:31:05 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1559539865; bh=5wWfJRnDdA9FiLmYPLsdG8JR3jEP1DkwjANbaq2rt54=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=lzlAjML+u2qUUhdVj9q7gFcF+8KnsWxhtapmEoZ8OThMFDmn0hEqvTou0+iYYRbRN LY4E/S/18enl69N343wy70jJKPhi4VEfEn5WZWpO2u9xXsufuxpklWDiFDInL+duI5 PgWkgXpnDr3735J4JwF1WEwy1BMTCnGLKmfqle4s=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5ADXW3SVEC4CAVVCV3AHRRTEVBNHHBVYEEBE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2762/review/244684013@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2762@github.com>
References: <quicwg/base-drafts/pull/2762@github.com>
Subject: Re: [quicwg/base-drafts] Mandate allowing peer to create enough unidirectional streams for HTTP and QPACK (#2762)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cf4b09919689_7c573fdbdf8cd96c29605f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8qjBjV2USNOVs2CMyFmNsJ6-ZNU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Jun 2019 05:31:09 -0000

kazuho commented on this pull request.



> @@ -912,10 +912,20 @@ Endpoints that set low values for the QUIC transport parameters
 chance that the remote peer reaches the limit early and becomes blocked. In
 particular, the value chosen for `initial_max_uni_streams` should consider that
 remote peers may wish to exercise reserved stream behaviour ({{stream-grease}}).
-To reduce the likelihood of blocking, both clients and servers SHOULD send a
-value of three or greater for the QUIC transport parameter
-`initial_max_uni_streams`, and a value of 1,024 or greater for the QUIC
-transport parameter `initial_max_stream_data_uni`.
+To reduce the likelihood of blocking, both clients and servers MUST allow
+the peer to create one unidirectional stream for the HTTP control stream plus

Maybe it would be better to state "create _at least_", to avoid the confusion that the endpoints are expected to allow creation *exactly* three streams.

> @@ -912,10 +912,20 @@ Endpoints that set low values for the QUIC transport parameters
 chance that the remote peer reaches the limit early and becomes blocked. In
 particular, the value chosen for `initial_max_uni_streams` should consider that
 remote peers may wish to exercise reserved stream behaviour ({{stream-grease}}).
-To reduce the likelihood of blocking, both clients and servers SHOULD send a
-value of three or greater for the QUIC transport parameter
-`initial_max_uni_streams`, and a value of 1,024 or greater for the QUIC
-transport parameter `initial_max_stream_data_uni`.
+To reduce the likelihood of blocking, both clients and servers MUST allow

Maybe replacing "To reduce the likelihood of blocking" with "To avoid blocking" might make sense.

This is because there is in practice no chance of seeing the connection being blocked now that the text mandates endpoints allow the necessary number of streams to be open-able. The only case where blocking might still happen is when the peer might grease a unidirectional stream before creating the mandatory streams. But that causing blocking is unrelated to the provision of this paragraph.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2762#pullrequestreview-244684013