Re: [quicwg/base-drafts] QPACK improvement: wrap absolute index values (#1644)
Dmitri Tikhonov <notifications@github.com> Fri, 10 August 2018 12:57 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3342C130F61 for <quic-issues@ietfa.amsl.com>; Fri, 10 Aug 2018 05:57:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MbSmO0aTH2QZ for <quic-issues@ietfa.amsl.com>; Fri, 10 Aug 2018 05:57:40 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0DFB0130E1A for <quic-issues@ietf.org>; Fri, 10 Aug 2018 05:57:40 -0700 (PDT)
Date: Fri, 10 Aug 2018 05:57:38 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1533905858; bh=+K9eYBI+jmOQY8DWs3CChf5Jw1F4unC8Ki7uIo7VOJo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wBg6NkrOnpiCAqDLUZ9LzH0PjEMQnoTPJ6so+fEPVsscXb8e9s4J/AKSXuOMnXox7 wsCuy+0PMHO/anpGcB6ANaKDhlndA1/Eqqef1ex/ecf2XtNecE3H9OVh1UoHE80AWV VXU2aInDG7nn6swEPVQjbuw9rUfad9zIyyB/I5hg=
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab965bfa02eba95ae6bb3485c51055857a3c20095492cf0000000117854dc292a169ce14cf3287@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1644/412074314@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1644@github.com>
References: <quicwg/base-drafts/issues/1644@github.com>
Subject: Re: [quicwg/base-drafts] QPACK improvement: wrap absolute index values (#1644)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b6d8bc2be3d4_4acd3f8786cbe6283924e2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8sOqRqCNeyHpNPdSeNWjwD6z05M>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Aug 2018 12:57:51 -0000
I am glad that you approve the proposal, @MikeBishop and @martinthomson . I will create a PR. I agree: setting `CeilMul` to 1 is the best choice. It gives the index range the property of being exactly twice the size of the maximum size of the dynamic table. This permits some immediate optimizations in the implementation. I also agree that beginning the dynamic table at index 0 is better, as this is how most of us index arrays (C, C++, Go, etc.). Should this be a separate PR -- assuming that @afrind, @krasic, and @MikeBishop agree as well? Also, shall we start the static table with 0 for consistency's sake? The remarks regarding `floor()` and the 0-RTT scenario have been noted. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/1644#issuecomment-412074314
- [quicwg/base-drafts] QPACK improvement: wrap abso… Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Mike Bishop
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Mike Bishop
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Mike Bishop
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Mike Bishop
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Martin Thomson
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Mike Bishop
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Mike Bishop
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Martin Thomson
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Martin Thomson
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK improvement: wrap … afrind
- Re: [quicwg/base-drafts] QPACK improvement: wrap … afrind
- Re: [quicwg/base-drafts] QPACK improvement: wrap … Dmitri Tikhonov
- Re: [quicwg/base-drafts] QPACK improvement: wrap … afrind