Re: [quicwg/base-drafts] Notify the congestion controller of losses first (#3540)

ianswett <notifications@github.com> Tue, 31 March 2020 16:05 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 051B53A238E for <quic-issues@ietfa.amsl.com>; Tue, 31 Mar 2020 09:05:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.5
X-Spam-Level:
X-Spam-Status: No, score=-0.5 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=0.7, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rUKQq6NIXR0W for <quic-issues@ietfa.amsl.com>; Tue, 31 Mar 2020 09:05:08 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4A69A3A237A for <quic-issues@ietf.org>; Tue, 31 Mar 2020 09:05:08 -0700 (PDT)
Date: Tue, 31 Mar 2020 09:05:07 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1585670707; bh=FhIAVy+fE+66/IQ0FolUgjjetCYt31kvhGYYb7ue6ik=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=WL4zjol3MA4EKz7LUg6N708JBqKZhZs0DqTq+kpox451MRGiqhY2RrEVjXPGNB+k5 2/dpncOt5IuAPGHdWdiI4ttCB1eVPBEOPRxQRppm5JImZ7pTuoRur6Tc124XWfTsXI SBpZbG1032a8aPbpgAKVrWHYHyOToC0+pca/jRow=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYWYVCG2AECEXOLQDV4R5FTHEVBNHHCF2VMJI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3540/review/384883750@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3540@github.com>
References: <quicwg/base-drafts/pull/3540@github.com>
Subject: Re: [quicwg/base-drafts] Notify the congestion controller of losses first (#3540)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e836a333b788_542c3fb335ccd968195af"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/8vN639v75LK9m76V28jbqSipMdY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Mar 2020 16:05:10 -0000

@ianswett commented on this pull request.



> @@ -1265,7 +1244,8 @@ OnLossDetectionTimeout():
     GetEarliestTimeAndSpace(loss_time)
   if (earliest_loss_time != 0):
     // Time threshold loss Detection
-    DetectLostPackets(pn_space)
+    lost_packets = DetectLostPackets(pn_space)
+    OnPacketsLost(lost_packets)

If a timeout occurred, then lost_packets should never be empty I believe?  I could add an assert for that if you'd like?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3540#discussion_r401033422