Re: [quicwg/base-drafts] Allow CONNECTION_CLOSE in 0-RTT (#3440)

ianswett <notifications@github.com> Thu, 06 February 2020 17:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 84DD01200F4 for <quic-issues@ietfa.amsl.com>; Thu, 6 Feb 2020 09:12:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id njpKFmbc-zdO for <quic-issues@ietfa.amsl.com>; Thu, 6 Feb 2020 09:12:54 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8405C1200F6 for <quic-issues@ietf.org>; Thu, 6 Feb 2020 09:12:54 -0800 (PST)
Date: Thu, 06 Feb 2020 09:12:53 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581009173; bh=/6U0m/wigpYKwNOfjPFM6CfSEa0yb+mrCWLibvnkkro=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=XBRXj/MD+8j4vl19Bxhdl5vpxc9Bo103zTYsK/m7F8y7ZnV8JYznLHGG6zPTCIJyb 6LkBBH8VT1ODTN06chGxjJUlE2a19qv9CRzYerHxM15NiKus9QSbae+CB/RIqb7ej+ aU8cm1BYTw++j0tQ1vLbYdm8nZq9D6M09+hgYR5U=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2SBCVE4BY2S6INUVF4JF5ZLEVBNHHCC4MTBY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3440/review/354623198@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3440@github.com>
References: <quicwg/base-drafts/pull/3440@github.com>
Subject: Re: [quicwg/base-drafts] Allow CONNECTION_CLOSE in 0-RTT (#3440)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e3c4915c8e36_21723fc5588cd9648333ad"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9HyHX8wf4SgMIAztWZtHHjfKfKE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Feb 2020 17:12:58 -0000

ianswett approved this pull request.



> -least one of them is processable by the client.  Similarly, a peer might be
-unable to read 1-RTT packets, so an endpoint SHOULD send CONNECTION_CLOSE in
-Handshake and 1-RTT packets prior to confirming the handshake.  These packets
-can be coalesced into a single UDP datagram; see {{packet-coalesce}}.
+* A client will always know whether the server has Handshake keys (see
+  {{discard-initial}}), but it is possible that a server does not know whether
+  the client has Handshake keys.  Under these circumstances, a server SHOULD
+  send a CONNECTION_CLOSE frame in both Handshake and Initial packets to ensure
+  that at least one of them is processable by the client.
+
+* A client that sends CONNECTION_CLOSE in a 0-RTT packet cannot be assured of
+  the server has accepted 0-RTT and so sending a CONNECTION_CLOSE frame of type
+  0x1c in an Initial packet makes it more likely that the server can receive
+  the close signal, even if the application error code might not be received.
+
+* A peer might be unable to read 1-RTT packets, so an endpoint SHOULD send

Suggestion to reorder this sentence: "Prior to confirming the handshake, a peer might be unable to process 1-RTT packets, so an endpoint SHOULD send CONNECTION_CLOSE in Handshake and 1-RTT packets."

> +* A client will always know whether the server has Handshake keys (see
+  {{discard-initial}}), but it is possible that a server does not know whether
+  the client has Handshake keys.  Under these circumstances, a server SHOULD
+  send a CONNECTION_CLOSE frame in both Handshake and Initial packets to ensure
+  that at least one of them is processable by the client.
+
+* A client that sends CONNECTION_CLOSE in a 0-RTT packet cannot be assured of
+  the server has accepted 0-RTT and so sending a CONNECTION_CLOSE frame of type
+  0x1c in an Initial packet makes it more likely that the server can receive
+  the close signal, even if the application error code might not be received.
+
+* A peer might be unable to read 1-RTT packets, so an endpoint SHOULD send
+  CONNECTION_CLOSE in Handshake and 1-RTT packets prior to confirming the
+  handshake.
+
+CONNECTION_CLOSE frames that are sent in multiple packets can be coalesced into

```suggestion
CONNECTION_CLOSE frames sent in multiple packets can be coalesced into
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3440#pullrequestreview-354623198