Re: [quicwg/base-drafts] Describe a new version negotiation mechanism which allows for (#1755)

Mike Bishop <notifications@github.com> Fri, 28 September 2018 16:32 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D376A128D0C for <quic-issues@ietfa.amsl.com>; Fri, 28 Sep 2018 09:32:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.456
X-Spam-Level:
X-Spam-Status: No, score=-3.456 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fBukzhJIkYoS for <quic-issues@ietfa.amsl.com>; Fri, 28 Sep 2018 09:32:34 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C4C8D130E6B for <quic-issues@ietf.org>; Fri, 28 Sep 2018 09:32:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=EmiUQldHrFPjEnXEK9+MvBeQk9I=; b=jxn3XzmthtN5iCBj N5Fqq8O2E21OZ1Wcu26zUTeTaYbva6lrd+ODYkmO6LH0BBsZf9jyzCdkLjUTv90C T6aFumWjoWnAsIeMUYlVKYj6zq66sKp/NW0MyEX4IrYegs4TeEJr5OWICp+z1Sa3 ZYYHcJT73LvnKW+q0rAR+W2uQTU=
Received: by filter1484p1mdw1.sendgrid.net with SMTP id filter1484p1mdw1-11571-5BAE57A0-16 2018-09-28 16:32:32.459553512 +0000 UTC m=+253140.654867534
Received: from github-lowworker-b40b5a4.cp1-iad.github.net (unknown [192.30.252.36]) by ismtpd0004p1iad2.sendgrid.net (SG) with ESMTP id c13fZKUxSAqzrCfUobgK3A for <quic-issues@ietf.org>; Fri, 28 Sep 2018 16:32:32.472 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-b40b5a4.cp1-iad.github.net (Postfix) with ESMTP id 71C4A3E005C for <quic-issues@ietf.org>; Fri, 28 Sep 2018 09:32:32 -0700 (PDT)
Date: Fri, 28 Sep 2018 16:32:32 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7e644851502f83cd0ef8f0656e64b4a2181e07b292cf0000000117c619a092a169ce1583704e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1755/review/159934736@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1755@github.com>
References: <quicwg/base-drafts/pull/1755@github.com>
Subject: Re: [quicwg/base-drafts] Describe a new version negotiation mechanism which allows for (#1755)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bae57a06aec8_3b2b3fb6d3ed45bc62845f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak34oTlSLfITJPTtqTUQGtUEgnPIyDBU5A27ig 2tpLhaB00opJYdYcSn4XgnktefUspzBkA4GbR1LutBtfysrii53om36rho/0EP8ZV/xxyzV0rNhVwY UWKd+vVlqVfTvgEVyivX/c0x+ZIPP9gEo55/QSTbukIRtidJg3scGd+OmHd9st3XLdom5K5cwJPE80 k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9OboWZl_57S5XbgvLklmQCu7CAM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Sep 2018 16:32:37 -0000

MikeBishop commented on this pull request.



> @@ -1773,75 +1793,9 @@ a transport parameter therefore disables any optional protocol feature that is
 negotiated using the parameter.
 
 New transport parameters can be registered according to the rules in
-{{iana-transport-parameters}}.
-
-
-### Version Negotiation Validation {#version-validation}

Build failure is because you've removed this section without updating the other places in the draft that reference it.  (Incidentally, the pre-commit hooks should have blocked you from committing something that doesn't build -- can you run `make update` to make sure that's installed?)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1755#pullrequestreview-159934736