Re: [quicwg/base-drafts] Allow ClientHello to span multiple QUIC packets (#3045)
ekr <notifications@github.com> Tue, 01 October 2019 20:48 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 15BC6120089 for <quic-issues@ietfa.amsl.com>; Tue, 1 Oct 2019 13:48:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.898
X-Spam-Level:
X-Spam-Status: No, score=-7.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CTKv8-rYUScX for <quic-issues@ietfa.amsl.com>; Tue, 1 Oct 2019 13:48:24 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 22BA612006F for <quic-issues@ietf.org>; Tue, 1 Oct 2019 13:48:24 -0700 (PDT)
Received: from github-lowworker-25680bd.va3-iad.github.net (github-lowworker-25680bd.va3-iad.github.net [10.48.17.61]) by smtp.github.com (Postfix) with ESMTP id 2133A6A0541 for <quic-issues@ietf.org>; Tue, 1 Oct 2019 13:48:23 -0700 (PDT)
Date: Tue, 01 Oct 2019 13:48:23 -0700
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZ43WTAQDTHRTN7B4N3UD6CPEVBNHHB26JPGY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3045/review/295883707@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3045@github.com>
References: <quicwg/base-drafts/pull/3045@github.com>
Subject: Re: [quicwg/base-drafts] Allow ClientHello to span multiple QUIC packets (#3045)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d93bb9712bea_18373f9f2dacd9682491f1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9OsFbDMrbSUsVdnHtGQif9VrGzA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Oct 2019 20:48:26 -0000
ekr approved this pull request. LGTM > -cryptographic handshake message, MUST fit in a single UDP datagram (see -{{handshake}}). The first CRYPTO frame sent always begins at an offset of 0 -(see {{handshake}}). - -Note that if the server sends a HelloRetryRequest, the client will send a second -Initial packet. This Initial packet will continue the cryptographic handshake -and will contain a CRYPTO frame with an offset matching the size of the CRYPTO -frame sent in the first Initial packet. Cryptographic handshake messages -subsequent to the first do not need to fit within a single UDP datagram. +the start or all of the first cryptographic handshake message. The first +CRYPTO frame sent always begins at an offset of 0 (see {{handshake}}). + +Note that if the server sends a HelloRetryRequest, the client will send another +series of Initial packets. These Initial packets will continue the +cryptographic handshake and will contain CRYPTO frames starting at an offset +matching the size of the CRYPTO frames sent in the first flight of Initial "matching the size" is a bit odd. Perhaps "immediately after the last byte of..." -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3045#pullrequestreview-295883707
- Re: [quicwg/base-drafts] Allow ClientHello to spa… Nick Banks
- [quicwg/base-drafts] Allow ClientHello to span mu… David Schinazi
- Re: [quicwg/base-drafts] Allow ClientHello to spa… Marten Seemann
- Re: [quicwg/base-drafts] Allow ClientHello to spa… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Allow ClientHello to spa… Kazuho Oku
- Re: [quicwg/base-drafts] Allow ClientHello to spa… Nick Banks
- Re: [quicwg/base-drafts] Allow ClientHello to spa… Kazuho Oku
- Re: [quicwg/base-drafts] Allow ClientHello to spa… Nick Banks
- Re: [quicwg/base-drafts] Allow ClientHello to spa… Kazuho Oku
- Re: [quicwg/base-drafts] Allow ClientHello to spa… Martin Thomson
- Re: [quicwg/base-drafts] Allow ClientHello to spa… MikkelFJ
- Re: [quicwg/base-drafts] Allow ClientHello to spa… Christopher Wood
- Re: [quicwg/base-drafts] Allow ClientHello to spa… MikkelFJ
- Re: [quicwg/base-drafts] Allow ClientHello to spa… David Schinazi
- Re: [quicwg/base-drafts] Allow ClientHello to spa… David Schinazi
- Re: [quicwg/base-drafts] Allow ClientHello to spa… David Schinazi
- Re: [quicwg/base-drafts] Allow ClientHello to spa… David Schinazi
- Re: [quicwg/base-drafts] Allow ClientHello to spa… MikkelFJ
- Re: [quicwg/base-drafts] Allow ClientHello to spa… Martin Thomson
- Re: [quicwg/base-drafts] Allow ClientHello to spa… David Schinazi
- Re: [quicwg/base-drafts] Allow ClientHello to spa… David Schinazi
- Re: [quicwg/base-drafts] Allow ClientHello to spa… ianswett
- Re: [quicwg/base-drafts] Allow ClientHello to spa… David Schinazi
- Re: [quicwg/base-drafts] Allow ClientHello to spa… David Schinazi
- Re: [quicwg/base-drafts] Allow ClientHello to spa… David Schinazi
- Re: [quicwg/base-drafts] Allow ClientHello to spa… David Schinazi
- Re: [quicwg/base-drafts] Allow ClientHello to spa… ianswett
- Re: [quicwg/base-drafts] Allow ClientHello to spa… ekr
- Re: [quicwg/base-drafts] Allow ClientHello to spa… Mike Bishop
- Re: [quicwg/base-drafts] Allow ClientHello to spa… Martin Thomson
- Re: [quicwg/base-drafts] Allow ClientHello to spa… Martin Thomson