Date: Tue, 01 Oct 2019 13:48:23 -0700
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKZ43WTAQDTHRTN7B4N3UD6CPEVBNHHB26JPGY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3045/review/295883707@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3045@github.com>
References: <quicwg/base-drafts/pull/3045@github.com>
Subject: Re: [quicwg/base-drafts] Allow ClientHello to span multiple QUIC
 packets (#3045)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5d93bb9712bea_18373f9f2dacd9682491f1";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9OsFbDMrbSUsVdnHtGQif9VrGzA>


----==_mimepart_5d93bb9712bea_18373f9f2dacd9682491f1
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ekr approved this pull request.

LGTM

> -cryptographic handshake message, MUST fit in a single UDP datagram (see
-{{handshake}}).  The first CRYPTO frame sent always begins at an offset of 0
-(see {{handshake}}).
-
-Note that if the server sends a HelloRetryRequest, the client will send a second
-Initial packet.  This Initial packet will continue the cryptographic handshake
-and will contain a CRYPTO frame with an offset matching the size of the CRYPTO
-frame sent in the first Initial packet.  Cryptographic handshake messages
-subsequent to the first do not need to fit within a single UDP datagram.
+the start or all of the first cryptographic handshake message.  The first
+CRYPTO frame sent always begins at an offset of 0 (see {{handshake}}).
+
+Note that if the server sends a HelloRetryRequest, the client will send another
+series of Initial packets.  These Initial packets will continue the
+cryptographic handshake and will contain CRYPTO frames starting at an offset
+matching the size of the CRYPTO frames sent in the first flight of Initial

"matching the size" is a bit odd. Perhaps "immediately after the last byte of..."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3045#pullrequestreview-295883707
----==_mimepart_5d93bb9712bea_18373f9f2dacd9682491f1
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ekr</b> approved this pull request.</p>

<p>LGTM</p><hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3045#discussion_r330267733">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; -cryptographic handshake message, MUST fit in a single UDP datagram (see
-{{handshake}}).  The first CRYPTO frame sent always begins at an offset of 0
-(see {{handshake}}).
-
-Note that if the server sends a HelloRetryRequest, the client will send a second
-Initial packet.  This Initial packet will continue the cryptographic handshake
-and will contain a CRYPTO frame with an offset matching the size of the CRYPTO
-frame sent in the first Initial packet.  Cryptographic handshake messages
-subsequent to the first do not need to fit within a single UDP datagram.
+the start or all of the first cryptographic handshake message.  The first
+CRYPTO frame sent always begins at an offset of 0 (see {{handshake}}).
+
+Note that if the server sends a HelloRetryRequest, the client will send another
+series of Initial packets.  These Initial packets will continue the
+cryptographic handshake and will contain CRYPTO frames starting at an offset
+matching the size of the CRYPTO frames sent in the first flight of Initial
</pre>
<p>"matching the size" is a bit odd. Perhaps "immediately after the last byte of..."</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3045?email_source=notifications&amp;email_token=AFTOJK3UHFNUALER56KWXQTQMOZRPA5CNFSM4IXMS4DKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGRNHOY#pullrequestreview-295883707">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK7POVAQMEWXTVOLZZLQMOZRPANCNFSM4IXMS4DA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AFTOJK35ELXXRBSD5ZS5JFLQMOZRPA5CNFSM4IXMS4DKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGRNHOY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3045?email_source=notifications\u0026email_token=AFTOJK3UHFNUALER56KWXQTQMOZRPA5CNFSM4IXMS4DKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGRNHOY#pullrequestreview-295883707",
"url": "https://github.com/quicwg/base-drafts/pull/3045?email_source=notifications\u0026email_token=AFTOJK3UHFNUALER56KWXQTQMOZRPA5CNFSM4IXMS4DKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGRNHOY#pullrequestreview-295883707",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5d93bb9712bea_18373f9f2dacd9682491f1--