IETF Logo Mail Archive

Re: [quicwg/base-drafts] Prohibit other frame types on CONNECT (#2702)

Jana Iyengar <notifications@github.com> Thu, 16 May 2019 01:38 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1CBD7120183 for <quic-issues@ietfa.amsl.com>; Wed, 15 May 2019 18:38:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RD5GFjwW3bE7 for <quic-issues@ietfa.amsl.com>; Wed, 15 May 2019 18:38:11 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A7BDB120041 for <quic-issues@ietf.org>; Wed, 15 May 2019 18:38:10 -0700 (PDT)
Date: Wed, 15 May 2019 18:38:09 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557970689; bh=5lu/jKJP7GHE/j+g13bPNZ3G83DrSgNeFmpO/+Lsbdc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=vwMEN4BLMpclHMtpAL0sssos6+gV1Udv3WRbKYPpDsKEgJduwEEbxbBCcREChCSGe lSBa2nbzpG6m1RlQPMxOma2B2gMdaBTZT+3y/ZHYSUTVkymfFlQJmAwTbScUOnbEFZ MybIffPhLLtY4283LNTcjN8mbQpxfdqDUgZlyAFs=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKY4OYUL3OZP55WCKLF25HYYDEVBNHHBU73QF4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2702/review/238143912@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2702@github.com>
References: <quicwg/base-drafts/pull/2702@github.com>
Subject: Re: [quicwg/base-drafts] Prohibit other frame types on CONNECT (#2702)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cdcbf0145699_304a3fb80aecd964936561"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9OvSIhPgZtJJBGPyvAzawG0ZGJs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 May 2019 01:38:13 -0000

janaiyengar approved this pull request.

nits

> @@ -1209,6 +1209,11 @@ TCP server; data received from the TCP server is packaged into DATA frames by
 the proxy. Note that the size and number of TCP segments is not guaranteed to
 map predictably to the size and number of HTTP DATA or QUIC STREAM frames.
 
+Once the CONNECT method has completed, only DATA frames are permitted
+to be sent on the stream.  (Extension frames MAY be used, if specifically

```suggestion
to be sent on the stream.  Extension frames MAY be used if specifically
```

> @@ -1209,6 +1209,11 @@ TCP server; data received from the TCP server is packaged into DATA frames by
 the proxy. Note that the size and number of TCP segments is not guaranteed to
 map predictably to the size and number of HTTP DATA or QUIC STREAM frames.
 
+Once the CONNECT method has completed, only DATA frames are permitted
+to be sent on the stream.  (Extension frames MAY be used, if specifically
+permitted by the extensions definition.)  Receipt of any other frame type

```suggestion
permitted by the definition of the extension.  Receipt of any other frame type
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2702#pullrequestreview-238143912

v2.23.0 | Report a Bug | By Email