IETF Logo Mail Archive

Re: [quicwg/base-drafts] VarInt all the HTTP things (#2437)

ianswett <notifications@github.com> Fri, 08 February 2019 16:41 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 20292127598 for <quic-issues@ietfa.amsl.com>; Fri, 8 Feb 2019 08:41:57 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.383
X-Spam-Level:
X-Spam-Status: No, score=-6.383 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1Ei2Q4qjzZbH for <quic-issues@ietfa.amsl.com>; Fri, 8 Feb 2019 08:41:55 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 15A161200ED for <quic-issues@ietf.org>; Fri, 8 Feb 2019 08:41:55 -0800 (PST)
Date: Fri, 08 Feb 2019 08:41:53 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549644113; bh=ggizSy4RIixl6MnW2hrwBTlafgJue4HqB3dRwCUyG28=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=OZUwvcWa397LpDY0TIaMaF4dk/oaYa5pTQKJo9dSCEavfpPWZ800ECZXXT1K3v7+t tUCJNVK/sujsa7Dp9pnMA0RIt1YpivKOPDjgzRxukPs6hKAnSldixdJVkqH9lToTJx Cv69rwafJWDAXBIAMjb6Rgxgjf0ii61vcgEymds4=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb26356a53474577ec09e67e3faff8e9b025a9dbe92cf000000011875735192a169ce1850d58f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2437/review/201674856@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2437@github.com>
References: <quicwg/base-drafts/pull/2437@github.com>
Subject: Re: [quicwg/base-drafts] VarInt all the HTTP things (#2437)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5db151b9b3f_52c83fd96d4d45b43188c2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9ZO7fclXGqqe67YTTUy3mtx24hE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Feb 2019 16:41:57 -0000

ianswett commented on this pull request.



> @@ -433,12 +437,10 @@ All frames have the following format:
 A frame includes the following fields:
 
   Type:
-  : An 8-bit type for the frame.
-
+  : A variable-length type for the frame.

+1

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2437#discussion_r255148468

v2.31.3 | Report a Bug | By Email | System Status