[quicwg/base-drafts] require peers to check if RETIRE_CONNECTION_ID sequence number is valid (#3036)

Marten Seemann <notifications@github.com> Mon, 16 September 2019 11:24 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0819D120836 for <quic-issues@ietfa.amsl.com>; Mon, 16 Sep 2019 04:24:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id avpIiMuWVzv0 for <quic-issues@ietfa.amsl.com>; Mon, 16 Sep 2019 04:24:35 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8CE5B120834 for <quic-issues@ietf.org>; Mon, 16 Sep 2019 04:24:35 -0700 (PDT)
Date: Mon, 16 Sep 2019 04:24:34 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1568633074; bh=uCzREmtp/7FIKQOfHLvk3AFjrYRrJzduSoJdFZOsOlM=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=mgc+ySmE7CHRGr2SRRdvJhiHOE4X0V2UMOTRfUu2YFLtCJZ77pUR+Y+AKfy+fnuZ0 0JUoUobPw1IsUnChLh03AgrynkEE6FC40SVoaeB/k+RfIdWLG2oxTbCqHk30zFL6c0 5n2hAXaxZuC7YebwMNXtO10ib4HWBCbmlyH76ifo=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYSKKA74OQDZ43ZD7N3RSRXFEVBNHHB24NSYI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3036@github.com>
Subject: [quicwg/base-drafts] require peers to check if RETIRE_CONNECTION_ID sequence number is valid (#3036)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d7f70f28a410_2fc53fba758cd95c6225c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9ZyVq1LRXB_6AyvJNe2VTRYMkEU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Sep 2019 11:24:37 -0000

When it comes to error checks for protocol violations, our principle is that easy to implement error checks are REQUIRED. Only error checks that might require a lot of state to perform are optional.

The check that the sequence number retired in a RETIRE_CONNECTION_ID frame is smaller than the highest issued connection ID is a single trivial uint64 comparison. Furthermore, every implementation needs to track the highest issued sequence number anyway, since connection IDs are issued in order.
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/3036

-- Commit Summary --

  * require peers to check if RETIRE_CONNECTION_ID sequence number is valid

-- File Changes --

    M draft-ietf-quic-transport.md (2)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/3036.patch
https://github.com/quicwg/base-drafts/pull/3036.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3036