Re: [quicwg/base-drafts] use max_ack_delay = 0 before receving the TPs (#2646)

Kazuho Oku <notifications@github.com> Wed, 24 April 2019 05:08 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DDAC11200D7 for <quic-issues@ietfa.amsl.com>; Tue, 23 Apr 2019 22:08:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.002
X-Spam-Level:
X-Spam-Status: No, score=-8.002 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5gTWQXs07RDb for <quic-issues@ietfa.amsl.com>; Tue, 23 Apr 2019 22:08:55 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2FA5D12069B for <quic-issues@ietf.org>; Tue, 23 Apr 2019 22:08:55 -0700 (PDT)
Date: Tue, 23 Apr 2019 22:08:53 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1556082533; bh=Lo68VOfAXxRC8HN4r7hT0sTFvcuujGVEc1uoXOYYtD4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oAqmJ8mkfZ9n1Ds6BpIT3G6KxsI+UL+5jpnZhHSLF2g5ZUM0N2dFFGb4Wn9x2ZvtD /7K3iyqXWm4ccuZkT9vZg+1fQkIQpOunLAMkZQ4IZ6N+P6pNsyuWs0s3a0Ig4z3Vb3 8HOe72MI2dTyQXTk90ilDemLu3zzGa057p7R8fns=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZNMK4Q3GKR74U7M652ZUQ6LEVBNHHBUA7M3M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2646/c486069860@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2646@github.com>
References: <quicwg/base-drafts/pull/2646@github.com>
Subject: Re: [quicwg/base-drafts] use max_ack_delay = 0 before receving the TPs (#2646)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cbfef65de50e_94d3fa890ccd9686563f3"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9jaycafmOLpUNB1SoxGaqy7aVx8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Apr 2019 05:08:57 -0000

@martinthomson 
> Let's do this right and set the value to 0 initially in the transport doc. The "crypto packet" hack is cute, but it's another special case, where this doesn't need a special case, just an initial value.

I think that using max-ack-delay 0 for crypto packets (to be precise, Initial and Hanshake packets)  is _not_ a hack. It's preferable.

The problem of respecting TP.max_ack_delay for Initial and Handshake packets, once receiving TP from the peer, is that loss recovery would kick in `TP.max_ack_delay` seconds later than they can (note: peer is required to send ACK ASAP).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2646#issuecomment-486069860