Date: Tue, 09 Jul 2019 23:51:35 -0700
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK2SJSMVXTVPBSTCR3V3GK6XPEVBNHHBXQE5FY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2880/review/259898405@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2880@github.com>
References: <quicwg/base-drafts/pull/2880@github.com>
Subject: Re: [quicwg/base-drafts] Articulate error code principles (#2880)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5d258af7d7a96_789c3f906aacd96c230734";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9muqNJHaNrg8kFjErqdqY4z-mm0>


----==_mimepart_5d258af7d7a96_789c3f906aacd96c230734
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

LPardue approved this pull request.



> @@ -5374,6 +5379,14 @@ CRYPTO_ERROR (0x1XX):
 
 See {{iana-error-codes}} for details of registering new error codes.
 
+In defining these error codes, several principles are applied.  Error conditions
+that might require specific action on the part of a recipient are giving unique

s/giving/given

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2880#pullrequestreview-259898405
----==_mimepart_5d258af7d7a96_789c3f906aacd96c230734
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@LPardue</b> approved this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2880#discussion_r301908915">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -5374,6 +5379,14 @@ CRYPTO_ERROR (0x1XX):
 
 See {{iana-error-codes}} for details of registering new error codes.
 
+In defining these error codes, several principles are applied.  Error conditions
+that might require specific action on the part of a recipient are giving unique
</pre>
<p>s/giving/given</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2880?email_source=notifications&amp;email_token=AFTOJK2JWAWYEKGOZWPXBTTP6WBHPA5CNFSM4H7CJCEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB563YJI#pullrequestreview-259898405">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK5PWIKX24D6Z2FCTTTP6WBHPANCNFSM4H7CJCEA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AFTOJK7K4BYSNXHQCCTILU3P6WBHPA5CNFSM4H7CJCEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB563YJI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2880?email_source=notifications\u0026email_token=AFTOJK2JWAWYEKGOZWPXBTTP6WBHPA5CNFSM4H7CJCEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB563YJI#pullrequestreview-259898405",
"url": "https://github.com/quicwg/base-drafts/pull/2880?email_source=notifications\u0026email_token=AFTOJK2JWAWYEKGOZWPXBTTP6WBHPA5CNFSM4H7CJCEKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB563YJI#pullrequestreview-259898405",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5d258af7d7a96_789c3f906aacd96c230734--