Re: [quicwg/base-drafts] Why do we have final size? (#3739)

[ianswett <[e-mail]>]

@ianswett commented on this pull request.

Some suggestions

> +The final size of a stream is always signaled to the recipient.  The final size
+is the sum of the Offset and Length fields of a STREAM frame with a FIN flag,
+noting that these fields might be implicit.  Alternatively, the Final Size field
+of a RESET_STREAM frame carries this value.  This ensures that all ways that a
+stream can be closed result in the number of bytes on the stream being reliably

I don't think this is quite correct, since there's not an implicit fin in the case of a stream where the Fin was never sent and the stream was reset.

```suggestion
The final size of a stream is always signaled to the recipient.  For streams that
are completed, the final size is the sum of the Offset and Length fields of a
STREAM frame with a FIN flag.  For a stream that is reset, the Final Size field
of a RESET_STREAM frame carries the final size.  This ensures that all ways that a
stream can be closed result in the number of bytes on the stream being reliably
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3739#pullrequestreview-426555319