Date: Mon, 08 Jun 2020 12:29:40 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK63P5IDKONEWMQ4RNF45JZKJEVBNHHCLJZEOA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3739/review/426555319@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3739@github.com>
References: <quicwg/base-drafts/pull/3739@github.com>
Subject: Re: [quicwg/base-drafts] Why do we have final size? (#3739)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5ede91a42a1d9_6e6e3fa94dccd9642918d4";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9pglasS0YZP191nyI7Z0twmHK7o>


----==_mimepart_5ede91a42a1d9_6e6e3fa94dccd9642918d4
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@ianswett commented on this pull request.

Some suggestions

> +The final size of a stream is always signaled to the recipient.  The final size
+is the sum of the Offset and Length fields of a STREAM frame with a FIN flag,
+noting that these fields might be implicit.  Alternatively, the Final Size field
+of a RESET_STREAM frame carries this value.  This ensures that all ways that a
+stream can be closed result in the number of bytes on the stream being reliably

I don't think this is quite correct, since there's not an implicit fin in the case of a stream where the Fin was never sent and the stream was reset.

```suggestion
The final size of a stream is always signaled to the recipient.  For streams that
are completed, the final size is the sum of the Offset and Length fields of a
STREAM frame with a FIN flag.  For a stream that is reset, the Final Size field
of a RESET_STREAM frame carries the final size.  This ensures that all ways that a
stream can be closed result in the number of bytes on the stream being reliably
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3739#pullrequestreview-426555319
----==_mimepart_5ede91a42a1d9_6e6e3fa94dccd9642918d4
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p></p>=0D
<p><b>@ianswett</b> commented on this pull request.</p>=0D
=0D
<p>Some suggestions</p><hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3739#discussi=
on_r436950107">draft-ietf-quic-transport.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; +The final size of a stream is always sign=
aled to the recipient.  The final size=0D
+is the sum of the Offset and Length fields of a STREAM frame with a FIN =
flag,=0D
+noting that these fields might be implicit.  Alternatively, the Final Si=
ze field=0D
+of a RESET_STREAM frame carries this value.  This ensures that all ways =
that a=0D
+stream can be closed result in the number of bytes on the stream being r=
eliably=0D
</pre>=0D
<p>I don't think this is quite correct, since there's not an implicit fin=
 in the case of a stream where the Fin was never sent and the stream was =
reset.</p>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-The final size of a stream is always signaled=
 to the recipient.  The final size=0D
-is the sum of the Offset and Length fields of a STREAM frame with a FIN =
flag,=0D
-noting that these fields might be implicit.  Alternatively, the Final Si=
ze field=0D
-of a RESET_STREAM frame carries this value.  This ensures that all ways =
that a=0D
-stream can be closed result in the number of bytes on the stream being r=
eliably=0D
+The final size of a stream is always signaled to the recipient.  For str=
eams that=0D
+are completed, the final size is the sum of the Offset and Length fields=
 of a=0D
+STREAM frame with a FIN flag.  For a stream that is reset, the Final Siz=
e field=0D
+of a RESET_STREAM frame carries the final size.  This ensures that all w=
ays that a=0D
+stream can be closed result in the number of bytes on the stream being r=
eliably=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/3739#pullrequestreview-426555319">view it on GitHub</=
a>, or <a href=3D"https://github.com/notifications/unsubscribe-auth/AFTOJ=
K4SP6PLEWEWR6N243TRVU32JANCNFSM4NUBN4WQ">unsubscribe</a>.<img src=3D"http=
s://github.com/notifications/beacon/AFTOJK6DGSZGFLZ5U2ETSVLRVU32JA5CNFSM4=
NUBN4W2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZ=
GODFWLPNY.gif" height=3D"1" width=3D"1" alt=3D"" /></p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/3739#pullrequestrev=
iew-426555319",=0D
"url": "https://github.com/quicwg/base-drafts/pull/3739#pullrequestreview=
-426555319",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5ede91a42a1d9_6e6e3fa94dccd9642918d4--