[quicwg/base-drafts] Clarify OnAckReceived pseudocode (#2140)

[Benjamin Saunders <[e-mail]>]

I ran into a few points of confusion in the existing code:
- The time to update and scope of `largest_acked_packet` is not explicit
- `ProcessECN` references elements of `sent_packets` after they are removed by `OnPacketAcked`
- `DetectLostPackets` is passed an undefined variable

The fixes are trivial, except for the last: it isn't clear to me whether `DetectLostPackets` was intended to be called with `ack.largest_acked` or `largest_acked_packet`. These only differ when ACKs are reordered, and because the prior invocation of `DetectLostPackets` with a higher `largest_acked` would have already deemed lost all packets that the later invocation might deem lost, I don't think the behavior differs even then. Hence, removing the argument and consistently referencing `largest_acked_packet` seems to be the simpler option.
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/2140

-- Commit Summary --

  * Process ECN before forgetting newly acked packets
  * Clarify use of largest_acked_packet

-- File Changes --

    M draft-ietf-quic-recovery.md (24)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/2140.patch
https://github.com/quicwg/base-drafts/pull/2140.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2140