IETF Logo Mail Archive

Re: [quicwg/base-drafts] Editorial-only NITS on QUIC-Transport-24 (#3214)

Mike Bishop <notifications@github.com> Thu, 30 January 2020 17:08 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E4CFD120020 for <quic-issues@ietfa.amsl.com>; Thu, 30 Jan 2020 09:08:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ax40s5NZgrwM for <quic-issues@ietfa.amsl.com>; Thu, 30 Jan 2020 09:08:50 -0800 (PST)
Received: from out-11.smtp.github.com (out-11.smtp.github.com [192.30.254.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 302DC120090 for <quic-issues@ietf.org>; Thu, 30 Jan 2020 09:08:50 -0800 (PST)
Received: from github-lowworker-56fcc46.va3-iad.github.net (github-lowworker-56fcc46.va3-iad.github.net [10.48.102.32]) by smtp.github.com (Postfix) with ESMTP id BBF292615A5 for <quic-issues@ietf.org>; Thu, 30 Jan 2020 09:08:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1580404129; bh=I0pls5RQl53AIRX1GUvB7BoRi4Rg2FEkkCVhDEKSUI0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=h2GBfQRdM+aKQ7fqnsPv4LjN0XZend05plAsSpgFy4OnkDWztZJYBERJeUBf7k6E0 SMhbE+4bdVkACiOr4WoJw1gtjD95VJj1l36LG1VWPUVJqDGjCJYd++BbGhjnkDDfRa AF3upjIX9rwGgEQufjSQPgWD39w4Rk9ndLBr/hrs=
Date: Thu, 30 Jan 2020 09:08:49 -0800
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZN73A6C72Z5EGLHPN4IBACDEVBNHHB6D2USA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3214/580356028@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3214@github.com>
References: <quicwg/base-drafts/issues/3214@github.com>
Subject: Re: [quicwg/base-drafts] Editorial-only NITS on QUIC-Transport-24 (#3214)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e330da177208_7de23fdeedacd9681481dc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9sbwiE7wGZyWdTSuO7duWLclWjs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jan 2020 17:08:52 -0000

PRs are a great way to fix *simple* editorial issues -- spelling, broken references, etc.  Things get dicey when an "editorial" PR changes the meaning or flow of the text and we don't want to take the whole of a given PR.  Then an editor needs to either accept the PR and partially revert it, or they need to duplicate the work for the things they want to keep.

Without looking super closely at the list of changes here, I probably wouldn't want to get a single PR that made all of these changes at once.  (Noting, of course, that this isn't my document.)

So my personal recommendation:
- Combination PRs for totally obvious editorial fixes
- Separate PRs for more invasive or controversial editorial fixes
- Issues for design changes and/or editorial issues where the solution isn't obvious (or you don't want to write it yourself)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3214#issuecomment-580356028

v2.23.0 | Report a Bug | By Email