Re: [quicwg/base-drafts] Introduce terms dynamic table capacity and maximum dynamic table capacity. (#2115)

Martin Thomson <notifications@github.com> Wed, 09 January 2019 04:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1182D129C6A for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 20:50:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d3SFBfpaVyZG for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 20:50:43 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3C2FB129AB8 for <quic-issues@ietf.org>; Tue, 8 Jan 2019 20:50:43 -0800 (PST)
Date: Tue, 08 Jan 2019 20:50:42 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547009442; bh=CCjpi6LsUgtjVINIiYeK2t/PY+vZ8gmg2W8FhFL5/s0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=PIZvbP0bSsefMd82KGcm8xsuzMPwoVyX6g4JM5zT3HsplMF8YpM3WXOEiyzo+NOaO XGQ8GCWFT65fz6zzCCNinD2oBZHy/V2hxmU3OZXjhRJNTBIqTeW1HCBi/nGFD8epn8 gauqQmbt6liGJm1UM5YwXACPhbZ2EOdBEC/FqeBw=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abfd61ccb0ed7c3badda85ae970e3a743b5669920692cf00000001184d3fa292a169ce173d8649@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2115/review/190572704@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2115@github.com>
References: <quicwg/base-drafts/pull/2115@github.com>
Subject: Re: [quicwg/base-drafts] Introduce terms dynamic table capacity and maximum dynamic table capacity. (#2115)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c357da24d4e8_d383f8abb6d45b84203c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9yMxA79U6Z0c8pJFy_JTieR_65g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jan 2019 04:50:45 -0000

martinthomson approved this pull request.

This is a good change.

> @@ -650,32 +656,31 @@ entries which are frequently referenced, both to avoid the need to resend the
 header and to avoid the entry in the table blocking the ability to insert new
 headers.
 
-### Dynamic Table Size Update {#size-update}
+### Dynamic Table Capacity Update {#capacity-update}

```suggestion
### Set Dynamic Table Capacity {#set-capacity}
```

Is this a better formulation?  Set is more direct.

Note that there are more places to fix than this, but you get the idea.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2115#pullrequestreview-190572704