Re: [quicwg/base-drafts] Make figures comply with 65-character limit (#1031)
janaiyengar <notifications@github.com> Mon, 25 December 2017 11:31 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 19A5A124205 for <quic-issues@ietfa.amsl.com>; Mon, 25 Dec 2017 03:31:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.596
X-Spam-Level:
X-Spam-Status: No, score=-5.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F7IPfrO7DJMp for <quic-issues@ietfa.amsl.com>; Mon, 25 Dec 2017 03:31:37 -0800 (PST)
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2-ext4.iad.github.net [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 504EC120725 for <quic-issues@ietf.org>; Mon, 25 Dec 2017 03:31:37 -0800 (PST)
Date: Mon, 25 Dec 2017 03:31:36 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1514201496; bh=h4bCPc/ISW6nOrbzGpJ2CYvaQCJhGyho+foOeypqmHU=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=NaAGYBvSIALZQuEUCJQKolsFu9wwEST6uZsfRd4crNPyyQ7DgmGR7tqA2O97kl/RE R0v1wW1Vn9xvMqmsVcu0phvis7RrSE1AIA1m0RanViqQnbdN5jkpP3w3FlVAbsNsJt Zvx8AgDlJzIThyLxFI8bBr5KQ+BqqXcnwbmwi4lM=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab695e97680758afb9a1fd57cab174d03680275e0792cf000000011658a39892a169ce10f34c45@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1031/review/85481449@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1031@github.com>
References: <quicwg/base-drafts/pull/1031@github.com>
Subject: Re: [quicwg/base-drafts] Make figures comply with 65-character limit (#1031)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5a40e1989f154_50e13ffbfbe90f34114948b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9z0lZBNfbO898V771JBcJgGlSRY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Dec 2017 11:31:39 -0000
janaiyengar approved this pull request.
LGTM, with one suggestion
> + // min_rtt ignores ack delay.
+ min_rtt = min(min_rtt, latest_rtt)
+ // Adjust for ack delay if it's plausible.
+ if (latest_rtt - min_rtt > ack_delay):
+ latest_rtt -= ack_delay
+ // Only save into max ack delay if it's used
+ // for rtt calculation and is not ack only.
+ if (!sent_packets[ack.largest_acked].ack_only)
+ max_ack_delay = max(max_ack_delay, ack_delay)
+ // Based on {{?RFC6298}}.
+ if (smoothed_rtt == 0):
+ smoothed_rtt = latest_rtt
+ rttvar = latest_rtt / 2
+ else:
+ rttvar = 3/4 * rttvar + 1/4 *
+ abs(smoothed_rtt - latest_rtt)
how about:
```
rttvar_sample = abs(smoothed_rtt - latest_rtt)
rttvar = 3/4 * rttvar + 1/4 * rttvar_sample
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1031#pullrequestreview-85481449
- [quicwg/base-drafts] Make figures comply with 65-… Mike Bishop
- Re: [quicwg/base-drafts] Make figures comply with… Mike Bishop
- Re: [quicwg/base-drafts] Make figures comply with… janaiyengar
- Re: [quicwg/base-drafts] Make figures comply with… Mike Bishop
- Re: [quicwg/base-drafts] Make figures comply with… ianswett
- Re: [quicwg/base-drafts] Make figures comply with… Martin Thomson