Date: Mon, 25 Dec 2017 03:31:36 -0800
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab695e97680758afb9a1fd57cab174d03680275e0792cf000000011658a39892a169ce10f34c45@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1031/review/85481449@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1031@github.com>
References: <quicwg/base-drafts/pull/1031@github.com>
Subject: Re: [quicwg/base-drafts] Make figures comply with 65-character limit
 (#1031)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5a40e1989f154_50e13ffbfbe90f34114948b";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/9z0lZBNfbO898V771JBcJgGlSRY>


----==_mimepart_5a40e1989f154_50e13ffbfbe90f34114948b
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

janaiyengar approved this pull request.

LGTM, with one suggestion

> +    // min_rtt ignores ack delay.
+    min_rtt = min(min_rtt, latest_rtt)
+    // Adjust for ack delay if it's plausible.
+    if (latest_rtt - min_rtt > ack_delay):
+      latest_rtt -= ack_delay
+      // Only save into max ack delay if it's used
+      // for rtt calculation and is not ack only.
+      if (!sent_packets[ack.largest_acked].ack_only)
+        max_ack_delay = max(max_ack_delay, ack_delay)
+    // Based on {{?RFC6298}}.
+    if (smoothed_rtt == 0):
+      smoothed_rtt = latest_rtt
+      rttvar = latest_rtt / 2
+    else:
+      rttvar = 3/4 * rttvar + 1/4 *
+        abs(smoothed_rtt - latest_rtt)

how about:
```
rttvar_sample = abs(smoothed_rtt - latest_rtt)
rttvar = 3/4 * rttvar + 1/4 * rttvar_sample
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1031#pullrequestreview-85481449
----==_mimepart_5a40e1989f154_50e13ffbfbe90f34114948b
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@janaiyengar</b> approved this pull request.</p>

<p>LGTM, with one suggestion</p><hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1031#discussion_r158639310">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; +    // min_rtt ignores ack delay.
+    min_rtt = min(min_rtt, latest_rtt)
+    // Adjust for ack delay if it&#39;s plausible.
+    if (latest_rtt - min_rtt &gt; ack_delay):
+      latest_rtt -= ack_delay
+      // Only save into max ack delay if it&#39;s used
+      // for rtt calculation and is not ack only.
+      if (!sent_packets[ack.largest_acked].ack_only)
+        max_ack_delay = max(max_ack_delay, ack_delay)
+    // Based on {{?RFC6298}}.
+    if (smoothed_rtt == 0):
+      smoothed_rtt = latest_rtt
+      rttvar = latest_rtt / 2
+    else:
+      rttvar = 3/4 * rttvar + 1/4 *
+        abs(smoothed_rtt - latest_rtt)
</pre>
<p>how about:</p>
<pre><code>rttvar_sample = abs(smoothed_rtt - latest_rtt)
rttvar = 3/4 * rttvar + 1/4 * rttvar_sample
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/1031#pullrequestreview-85481449">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq3mtLfwfcSxo7EUCZ1aRlXrORXbmks5tD4eYgaJpZM4RMATZ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AWbkq4GCEGMADHudxJce76nz8wZrEG_Nks5tD4eYgaJpZM4RMATZ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/quicwg/base-drafts/pull/1031#pullrequestreview-85481449"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@janaiyengar approved #1031"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1031#pullrequestreview-85481449"}}}</script>
----==_mimepart_5a40e1989f154_50e13ffbfbe90f34114948b--