Re: [quicwg/base-drafts] Make transport parameters varint (#3087)
Marten Seemann <notifications@github.com> Sun, 13 October 2019 11:44 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 833F0120024 for <quic-issues@ietfa.amsl.com>; Sun, 13 Oct 2019 04:44:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mW7bKsaajGLt for <quic-issues@ietfa.amsl.com>; Sun, 13 Oct 2019 04:44:39 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5EC6E12003E for <quic-issues@ietf.org>; Sun, 13 Oct 2019 04:44:39 -0700 (PDT)
Received: from github-lowworker-943b171.ac4-iad.github.net (github-lowworker-943b171.ac4-iad.github.net [10.52.22.59]) by smtp.github.com (Postfix) with ESMTP id 8649CA076A for <quic-issues@ietf.org>; Sun, 13 Oct 2019 04:44:38 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1570967078; bh=iDmH3WFpxPJJLTQYqlCVmmCknYHMs/nxXfFevsQDHnw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=axREXsq5Sd8tkmREGK84Se9/NfGoWhbp/QJbtEJ6HD7W689CqXvPmbTD5d0GDqaDT 1wD+CjiYcFuY+bY+ZwUD6Vjzd4bY960G4Lk+POpaFiSEcmc8Xw/gCJj57Q/MVQyMVL P9MO7jg4+89iwkdh8knC82LAfCQR7sBhMnUtr/lY=
Date: Sun, 13 Oct 2019 04:44:38 -0700
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7FAQNJ5GQOWZDBKRF3WBHLNEVBNHHB4KOWU4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3087/review/301045128@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3087@github.com>
References: <quicwg/base-drafts/pull/3087@github.com>
Subject: Re: [quicwg/base-drafts] Make transport parameters varint (#3087)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da30e2675ce7_78aa3fce130cd96c24916e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/A4yzO3hGSq-mlv53_tAuDQJFVsE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Oct 2019 11:44:43 -0000
marten-seemann commented on this pull request.
Thanks for this PR! This clarifies what you're suggesting on the issue.
> @@ -4361,42 +4361,43 @@ connection.
# Transport Parameter Encoding {#transport-parameter-encoding}
-The format of the transport parameters is the TransportParameters struct from
-{{figure-transport-parameters}}. This is described using the presentation
-language from Section 3 of {{!TLS13=RFC8446}}.
+The `extension_data` field of the quic_transport_parameters extension defined in
+{{QUIC-TLS}} contains the QUIC transport parameters. They are encoded as a
+sequence of transport parameters, as shown in {{transport-parameter-sequence}}:
We could consider making this an ordered list. This would simplify the check that the peer didn't send any duplicate transport parameters.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3087#pullrequestreview-301045128
- [quicwg/base-drafts] Make transport parameters va… David Schinazi
- Re: [quicwg/base-drafts] Make transport parameter… ekr
- Re: [quicwg/base-drafts] Make transport parameter… David Schinazi
- Re: [quicwg/base-drafts] Make transport parameter… Marten Seemann
- Re: [quicwg/base-drafts] Make transport parameter… David Schinazi
- Re: [quicwg/base-drafts] Make transport parameter… Mike Bishop
- Re: [quicwg/base-drafts] Make transport parameter… Martin Thomson
- Re: [quicwg/base-drafts] Make transport parameter… David Schinazi
- Re: [quicwg/base-drafts] Make transport parameter… David Schinazi