Re: [quicwg/base-drafts] Reset PTO and loss detection timer when discarding keys (#3415)

Jana Iyengar <> Fri, 28 February 2020 00:33 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id BF10A3A0A2F for <>; Thu, 27 Feb 2020 16:33:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -1.696
X-Spam-Status: No, score=-1.696 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id o_-Goj9gJDu4 for <>; Thu, 27 Feb 2020 16:33:21 -0800 (PST)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 7F40B3A0A2E for <>; Thu, 27 Feb 2020 16:33:21 -0800 (PST)
Date: Thu, 27 Feb 2020 16:33:20 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1582850000; bh=0D4FuymGZT4f7jQWLTNq7RhNPqSAUktZk7plEmbjDuc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=J7ovOnvDzkE9WwE/ejA5VQ5t6+tUspG3TsNB1f2pGU7pB8n5pUPug8mrwCvXIKKe0 jP0IbV5Bhg3nkVu8wSItVDmyM3n6CaZr7PnLIeMDBT7naMIpKQ8ccifFi/zODziniq LkKbwp9JSEETRSvl07y+BU2f8f5R3XI/KkzfBiDg=
From: Jana Iyengar <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3415/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Reset PTO and loss detection timer when discarding keys (#3415)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e585fd0c7995_110a3fb06cecd96416765d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Fri, 28 Feb 2020 00:33:23 -0000

janaiyengar commented on this pull request.

Looks fine, but is there a reason to not require this?

> @@ -531,6 +531,9 @@ bytes.
 Initial packets and Handshake packets could be never acknowledged, but they are
 removed from bytes in flight when the Initial and Handshake keys are discarded.
+When Initial or Handshake keys are discarded, the PTO and loss detection timers
+are reset, because discarding keys indicates forward progress and the loss

MUST be reset, because discarding keys indicates forward progress and the loss

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: