Re: [quicwg/base-drafts] Reword closing confirmation text (#2459)

Kazuho Oku <notifications@github.com> Wed, 13 February 2019 00:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 55F01130E11 for <quic-issues@ietfa.amsl.com>; Tue, 12 Feb 2019 16:49:23 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SXuN38B3kEXm for <quic-issues@ietfa.amsl.com>; Tue, 12 Feb 2019 16:49:21 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C7CF6130EA7 for <quic-issues@ietf.org>; Tue, 12 Feb 2019 16:49:20 -0800 (PST)
Date: Tue, 12 Feb 2019 16:49:19 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550018959; bh=HR41WndyAE6UhIc/R3S6fiY/EzeyEkoG/hIKHYmC8ic=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=GQ7x5RNcJBziT/eZJJYjCWNaVWnE/7XeWOm1VBl3aVTeS6rxUby2u+iE7cjGQwj8i FcXyKOUDhhfeJBl6m5OocF3K0kQSLuSpJ8NliYiEHbDNZdSmavZhsINnuTJSjr3Qr+ 1BJmhqr/1SAMeCEfibVrEyG+j/RfkcSIYUaa0eCI=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab770cf8a1ecd40bb409b0670398e901c22e76225592cf00000001187b2b8f92a169ce18697b69@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2459/review/202983575@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2459@github.com>
References: <quicwg/base-drafts/pull/2459@github.com>
Subject: Re: [quicwg/base-drafts] Reword closing confirmation text (#2459)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c63698fdbb02_60253fe593ed45b4247121"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/AAIMIh9At2W4B4qxF-ueFworMCA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Feb 2019 00:49:23 -0000

kazuho commented on this pull request.



> @@ -2156,11 +2156,10 @@ endpoint in the draining state MUST NOT send any packets.  Retaining packet
 protection keys is unnecessary once a connection is in the draining state.
 
 An endpoint MAY transition from the closing period to the draining period if it
-can confirm that its peer is also closing or draining.  Receiving a
-CONNECTION_CLOSE frame is sufficient confirmation, as is receiving a stateless
-reset.  The draining period SHOULD end when the closing period would have ended.
-In other words, the endpoint can use the same end time, but cease retransmission
-of the closing packet.
+can receives a CONNECTION_CLOSE frame or stateless reset, both of which indicate

s/can receives/receives/?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2459#pullrequestreview-202983575