Date: Sat, 14 Jul 2018 11:24:23 -0700
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abe7355ce62980555280fa260660aa166bbc226e5992cf00000001176201d792a169ce14571c59@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1562/review/137245304@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1562@github.com>
References: <quicwg/base-drafts/pull/1562@github.com>
Subject: Re: [quicwg/base-drafts] Security considerations (#1562)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5b4a3fd78c394_4cb2ae55309af5c101099";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ACbRCMU-dd5qB1DV_j8cUuy7h6I>


----==_mimepart_5b4a3fd78c394_4cb2ae55309af5c101099
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

janaiyengar commented on this pull request.



> @@ -1148,6 +1148,23 @@ retransmission timeout has been verified.
      congestion_window = kMinimumWindow
 ~~~
 
+# Security Considerations
+
+## Local Denial of Service
+
+QUIC requires congestion control, and recommends Reno. Not using a
+congestion control algorithm or using an overly aggressive
+algorithm may cause flows sharing the same link to experience
+excess delay, packet loss, and timeouts.

I don't think we need this one. I'll add a paragraph that says something about congestion control being required and Reno being the one that we describe in this doc, and point to 8085 for the rest.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1562#pullrequestreview-137245304
----==_mimepart_5b4a3fd78c394_4cb2ae55309af5c101099
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@janaiyengar</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1562#discussion_r202521931">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1148,6 +1148,23 @@ retransmission timeout has been verified.
      congestion_window = kMinimumWindow
 ~~~
 
+# Security Considerations
+
+## Local Denial of Service
+
+QUIC requires congestion control, and recommends Reno. Not using a
+congestion control algorithm or using an overly aggressive
+algorithm may cause flows sharing the same link to experience
+excess delay, packet loss, and timeouts.
</pre>
<p>I don't think we need this one. I'll add a paragraph that says something about congestion control being required and Reno being the one that we describe in this doc, and point to 8085 for the rest.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/1562#pullrequestreview-137245304">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq79Rd6r8yJnSdxmdT_Ioo4zm82jaks5uGjdXgaJpZM4VP77W">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq3GbTIe1bHqv_cyqeYi9d7HGKey6ks5uGjdXgaJpZM4VP77W.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@janaiyengar commented on #1562"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1562#pullrequestreview-137245304"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/1562#pullrequestreview-137245304",
"url": "https://github.com/quicwg/base-drafts/pull/1562#pullrequestreview-137245304",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@janaiyengar commented on 1562",
"sections": [
{
"text": "",
"activityTitle": "**janaiyengar**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@janaiyengar",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1562#pullrequestreview-137245304"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 356499158\n}"
}
],
"themeColor": "26292E"
}
]</script>
----==_mimepart_5b4a3fd78c394_4cb2ae55309af5c101099--