Re: [quicwg/base-drafts] QPACK: make TSS=0 a connection error (#1762)

Dmitri Tikhonov <notifications@github.com> Wed, 19 September 2018 18:20 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8A43A127B92 for <quic-issues@ietfa.amsl.com>; Wed, 19 Sep 2018 11:20:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q42ljFuhsNrn for <quic-issues@ietfa.amsl.com>; Wed, 19 Sep 2018 11:20:03 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A6235128BAC for <quic-issues@ietf.org>; Wed, 19 Sep 2018 11:20:03 -0700 (PDT)
Date: Wed, 19 Sep 2018 11:20:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537381202; bh=ytZUv8jrumZmjJuCk9I1trLYFrFXMqsHs3xWunGrlFY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=IWjna34kjFoadXaMQDDLFSsJOpQrMBbBoNBaa0xx1CDe3RLr/ANGHTSWEAdWcwFSr GviISrYMaPYZUFcutnPGitNcquMnM1OPpXM/BPMTugJZqNovVkn4YNRB0ihR65wP3c UctIYtFkasn49zNXj8fKAQHd3xVuVo1o5F3ieyW0=
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab45427cc283e8d0621242cc9352dfac7148ea448692cf0000000117ba555292a169ce158602f3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1762/review/156956919@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1762@github.com>
References: <quicwg/base-drafts/pull/1762@github.com>
Subject: Re: [quicwg/base-drafts] QPACK: make TSS=0 a connection error (#1762)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ba2935290f63_3a393fd3c58d45b8790f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/AGxm6Oz1-VVwYCd5wbHEXtX4vzk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Sep 2018 18:20:05 -0000

dtikhonov commented on this pull request.



> @@ -587,9 +587,10 @@ entries might cause a stream to become blocked, as described in
 ~~~~~~~~~~
 {:#fig-size-sync title="Table State Synchronize"}
 
-An encoder that receives an Insert Count that is greater than the number of
-dynamic table entries beyond the current Largest Known Received entry MUST treat
-this as a connection error of type `HTTP_QPACK_DECODER_STREAM_ERROR`.
+An encoder that receives an Insert Count equal to zero, or that is greater than

OK, mine was just an example.  I'd split the sentence into two to make it unambiguous and easier to read.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1762#discussion_r218911754