Re: [quicwg/base-drafts] Attempt to define slow start/congestion avoidance (#4005)

ianswett <notifications@github.com> Mon, 17 August 2020 15:10 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 672A93A10DD for <quic-issues@ietfa.amsl.com>; Mon, 17 Aug 2020 08:10:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Level:
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vRPuTNFvOReV for <quic-issues@ietfa.amsl.com>; Mon, 17 Aug 2020 08:10:19 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DEC233A10C2 for <quic-issues@ietf.org>; Mon, 17 Aug 2020 08:10:18 -0700 (PDT)
Received: from github-lowworker-292e294.va3-iad.github.net (github-lowworker-292e294.va3-iad.github.net [10.48.102.70]) by smtp.github.com (Postfix) with ESMTP id 04DDC521567 for <quic-issues@ietf.org>; Mon, 17 Aug 2020 08:10:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597677018; bh=0AQMwqvcN/nrVbC447N+X6gmLZRsjvEYRWEzIOnEB6I=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Cl4QyB5ze3MjWr9i1+gLbpxaNQX+KX9zzmz+coJNuEXAsFbqTyjy+jc7MHumJKJbk oJdM1flzG34sZaFts4p8/vgeuCGhQ33HQIqibK4S3JqLPORFpzr+JLBfXfM+rASCVR V2LTEKFrfm+/SpTeL1Znygw8pUwlmPWyZgmfX5DM=
Date: Mon, 17 Aug 2020 08:10:17 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2XT7AGFVPXMDV2EMN5IZ7NTEVBNHHCRBYB7A@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4005/review/468544666@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4005@github.com>
References: <quicwg/base-drafts/pull/4005@github.com>
Subject: Re: [quicwg/base-drafts] Attempt to define slow start/congestion avoidance (#4005)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f3a9dd9e9b05_7a7319642283a8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/AHuhBHqw3IaI-T0JI33Sr9CKDnU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Aug 2020 15:10:20 -0000

@ianswett approved this pull request.

This is likely to conflict with #3978

>  
 ## Congestion Avoidance
 
-Slow start exits to congestion avoidance.  Congestion avoidance uses an
-Additive Increase Multiplicative Decrease (AIMD) approach that increases
-the congestion window by one maximum packet size per congestion window
-acknowledged.  When a loss or ECN-CE marking is detected, NewReno halves
-the congestion window, sets the slow start threshold to the new
-congestion window, and then enters the recovery period.
+The congestion controller is in congestion avoidance any time the congestion
+window is at or above the slow start threshold.
+
+Congestion avoidance uses an Additive Increase Multiplicative Decrease (AIMD)
+approach that increases the congestion window by one maximum packet size per
+congestion window acknowledged.
+
+When first entering congestion avoidance, when a packet is declared lost, or
+when the ECN-CE count is detected, the congestion controller halves the

```suggestion
when the ECN-CE marking is detected, the congestion controller halves the
```

> -Additive Increase Multiplicative Decrease (AIMD) approach that increases
-the congestion window by one maximum packet size per congestion window
-acknowledged.  When a loss or ECN-CE marking is detected, NewReno halves
-the congestion window, sets the slow start threshold to the new
-congestion window, and then enters the recovery period.
+The congestion controller is in congestion avoidance any time the congestion
+window is at or above the slow start threshold.
+
+Congestion avoidance uses an Additive Increase Multiplicative Decrease (AIMD)
+approach that increases the congestion window by one maximum packet size per
+congestion window acknowledged.
+
+When first entering congestion avoidance, when a packet is declared lost, or
+when the ECN-CE count is detected, the congestion controller halves the
+congestion window, reduces the slow start threshold to the resulting size, and
+enters the recovery period.

I think you're correct, do you have a good RFC reference handy?  I couldn't easily find this text.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4005#pullrequestreview-468544666