Date: Mon, 15 Apr 2019 12:45:46 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab37d176116ec0e114d11e24050acb0306e2e77e0792cebac211ea92a169ce19cbf73c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2617/review/226844422@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2617@github.com>
References: <quicwg/base-drafts/pull/2617@github.com>
Subject: Re: [quicwg/base-drafts] Set loss delay at least kGranularity (#2617)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5cb4df6a313fa_173a3f7f0d0d45b4109668";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/AKLw6cxFnMOqVCSxR7LjyTvzwoI>


----==_mimepart_5cb4df6a313fa_173a3f7f0d0d45b4109668
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.



> @@ -486,6 +486,13 @@ Using max(SRTT, latest_RTT) protects from the two following cases:
 * the latest RTT sample is higher than the SRTT, perhaps due to a sustained
   increase in the actual RTT, but the smoothed SRTT has not yet caught up.
 
+An endpoint might consistently record RTT samples as 0 in extremely low latency
+networks, leading to a smoothed_rtt of 0.  Consequently, the endpoint could
+declare all packets as lost immediately upon receiving an acknowledgement for a

```suggestion
declare all earlier packets as lost immediately upon receiving an acknowledgement for a
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2617#pullrequestreview-226844422
----==_mimepart_5cb4df6a313fa_173a3f7f0d0d45b4109668
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@ianswett</b> commented on this pull request.</p>=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/2617#discussi=
on_r275516790">draft-ietf-quic-recovery.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -486,6 +486,13 @@ Using max(SRTT, lates=
t_RTT) protects from the two following cases:=0D
 * the latest RTT sample is higher than the SRTT, perhaps due to a sustai=
ned=0D
   increase in the actual RTT, but the smoothed SRTT has not yet caught u=
p.=0D
 =0D
+An endpoint might consistently record RTT samples as 0 in extremely low =
latency=0D
+networks, leading to a smoothed_rtt of 0.  Consequently, the endpoint co=
uld=0D
+declare all packets as lost immediately upon receiving an acknowledgemen=
t for a=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-declare all packets as lost immediately upon =
receiving an acknowledgement for a=0D
+declare all earlier packets as lost immediately upon receiving an acknow=
ledgement for a=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/2617#pullrequestreview-226844422">view it on GitHub</=
a>, or <a href=3D"https://github.com/notifications/unsubscribe-auth/AWbkq=
zd5Qd3ZUHWTvPV71c1MPqEaLMmvks5vhNbqgaJpZM4ctys4">mute the thread</a>.<img=
 src=3D"https://github.com/notifications/beacon/AWbkq6j928J53DNOcRIqG84nr=
T4TSr3sks5vhNbqgaJpZM4ctys4.gif" height=3D"1" width=3D"1" alt=3D"" /></p>=
=0D
<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio=
n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"=
:"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"=
quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"http=
s://github.githubassets.com/images/email/message_cards/header.png","avata=
r_image_url":"https://github.githubassets.com/images/email/message_cards/=
avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/q=
uicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@=
ianswett commented on #2617"}],"action":{"name":"View Pull Request","url"=
:"https://github.com/quicwg/base-drafts/pull/2617#pullrequestreview-22684=
4422"}}}</script>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/2617#pullrequestrev=
iew-226844422",=0D
"url": "https://github.com/quicwg/base-drafts/pull/2617#pullrequestreview=
-226844422",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5cb4df6a313fa_173a3f7f0d0d45b4109668--