IETF Logo Mail Archive

Re: [quicwg/base-drafts] Remap STOPPING to something other than zero (#1804)

Nick Banks <notifications@github.com> Wed, 26 September 2018 14:44 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BCB7C130E73 for <quic-issues@ietfa.amsl.com>; Wed, 26 Sep 2018 07:44:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.456
X-Spam-Level:
X-Spam-Status: No, score=-8.456 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LrizTtSW7_Uz for <quic-issues@ietfa.amsl.com>; Wed, 26 Sep 2018 07:44:41 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 08E81130DCB for <quic-issues@ietf.org>; Wed, 26 Sep 2018 07:44:38 -0700 (PDT)
Date: Wed, 26 Sep 2018 07:44:37 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537973077; bh=GV+MBJepoWESkVEQu92MV5z6z7+yZGpztiF2I2Y2QeY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=iGhJdEWbzRVTNrQ+nQuB1oQ6lLWZ22VUcuNMJhr2C5rfytyu1+7ARPXotCsf6keJE jtfDiWpFDOiphx8nBG8mBaqe1zjgZPszVG8LFYLCcfuqSLDwyVkMdRQ8rNm3LM0nZ1 fHcEZRCm4obQqZ9iSxu+VNiuKexwoiMXNKEowU2s=
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3efc20f7c27eb3d8b9e48962b4a160f290d8fc6992cf0000000117c35d5592a169ce15b0cecf@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1804/424741891@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1804@github.com>
References: <quicwg/base-drafts/issues/1804@github.com>
Subject: Re: [quicwg/base-drafts] Remap STOPPING to something other than zero (#1804)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bab9b55d5871_6a7a3fdc16ad45bc216943"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ANkjg4InLCrCGiBJZ6pB1MNASMc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Sep 2018 14:44:46 -0000

The app might have many 'success' error codes or use some bit field or anything... The API shouldn't make any assumptions. IMO, the app should just get an indication that the peer reset the stream, and here is the error code they provided. If you go the exception route, any time the reset happens you throw an exception that just contains the raw error code. You don't want your API not to support some protocol that was initially written on one API that allows for any value, because you made some assumption that gets broken.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1804#issuecomment-424741891

v2.31.3 | Report a Bug | By Email | System Status