Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)
mirjak <notifications@github.com> Mon, 18 June 2018 15:09 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4FF26130DE0 for <quic-issues@ietfa.amsl.com>; Mon, 18 Jun 2018 08:09:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3S5JlBB17Qs9 for <quic-issues@ietfa.amsl.com>; Mon, 18 Jun 2018 08:09:46 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 648C312777C for <quic-issues@ietf.org>; Mon, 18 Jun 2018 08:09:46 -0700 (PDT)
Date: Mon, 18 Jun 2018 08:09:45 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1529334585; bh=/ZIu7Rkkx8Bq6zFMAiydDZf2XYhmmRlMLmHDA8tHvuU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=HZ8UBaLfEloLBDa33ODqH34HUxr6NvjrpgGC7qMdz5Nue2yPhfICYwOw1YYcZOW/m 2sMOfKHsBcfP0ze5DYLWRLdo1V1QLwfAgAnv6HDKcs0kMApneBDslFghEmhusXHA0H fJeeB3sBPlhXB62JIT0UdVgiyD0qbIP0nDyuNR30=
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab995efdc38ba2533def845a508db7d56f4d39511292cf00000001173f8d3992a169ce13656182@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1372/review/129606871@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1372@github.com>
References: <quicwg/base-drafts/pull/1372@github.com>
Subject: Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b27cb39600a5_1a6a2ac7ae54af60110930"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mirjak
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/APQx7z4XDMJ4eo5_HbfA3eGfXTA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jun 2018 15:09:49 -0000
mirjak commented on this pull request. > @@ -2887,6 +3033,95 @@ by a client in protected packets, because it is certain that the server is able to decipher the packet. +## ACK_ECN Frame {#frame-ack-ecn} + +A QUIC connection MUST keep counters for each ECN codepoint, recording +the number of packets that were received with the corresponding ECN +codepoint in the IP header. If the header is not readable from the +application, the codepoint 00 (Not-ECT) MUST be assumed. If any packet +are duplicated by the network then only the value of the ECN field of +the packet copy first received SHALL be included in the counters, the ECN +field value for a duplicate SHALL be ignored. This to prevent the This is incorrect. The requirements that currently exists in tsv is that ALL CEs must be counted because the network does not know if a packet is a duplicate or not! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1372#discussion_r196114651
- Re: [quicwg/base-drafts] Proposal for adding ECN … Martin Thomson
- Re: [quicwg/base-drafts] Proposal for adding ECN … janaiyengar
- Re: [quicwg/base-drafts] Proposal for adding ECN … Martin Thomson
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Lars Eggert
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Martin Thomson
- Re: [quicwg/base-drafts] Proposal for adding ECN … Kazuho Oku
- Re: [quicwg/base-drafts] Proposal for adding ECN … Martin Thomson
- Re: [quicwg/base-drafts] Proposal for adding ECN … janaiyengar
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … mirjak
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … mirjak
- Re: [quicwg/base-drafts] Proposal for adding ECN … mirjak
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … mirjak
- Re: [quicwg/base-drafts] Proposal for adding ECN … Kazuho Oku
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Kazuho Oku
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … mirjak
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … Kazuho Oku
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Martin Thomson
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Lars Eggert
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- [quicwg/base-drafts] Proposal for adding ECN supp… Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … IngJohEricsson
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Martin Thomson
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Kazuho Oku
- Re: [quicwg/base-drafts] Proposal for adding ECN … Lars Eggert