IETF Logo Mail Archive

Re: [quicwg/base-drafts] Don't cite octet indices any more (#1437)

Mike Bishop <notifications@github.com> Mon, 11 June 2018 17:14 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8B4E0130E70 for <quic-issues@ietfa.amsl.com>; Mon, 11 Jun 2018 10:14:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ejnfdCsaQ4ja for <quic-issues@ietfa.amsl.com>; Mon, 11 Jun 2018 10:14:33 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 319DE130E3A for <quic-issues@ietf.org>; Mon, 11 Jun 2018 10:14:33 -0700 (PDT)
Date: Mon, 11 Jun 2018 10:14:32 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1528737272; bh=lG89cgfGkfn3i2TTdh3kPrf+q6gqSyjS0qEbAP1bnhs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Vqx5WIkacqzBR+u6HHmoEuXw/dMrvnVkLnLn3KtC4jA1dk4Nd0EHouo8ienyf2qyx x6ux8gBqZgWj6MjPrLJOgqWaDdl2Q1XWeVKQfAM/Rk4zVCYpVjwLTiqIAFfLTckzcn cYcu+Vhebl8U4OjBD3in9TKUNSpn5XmWz+VdH2lY=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abcc08fa120eb0b26be859e6aa0b74d3e3da0a957592cf0000000117366ff892a169ce13be915e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1437/review/127659775@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1437@github.com>
References: <quicwg/base-drafts/pull/1437@github.com>
Subject: Re: [quicwg/base-drafts] Don't cite octet indices any more (#1437)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b1eadf865e0b_3e552acf29810f603625ed"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/AVwcjWaRVB7uohKCKAbz7Jndjw8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2018 17:14:35 -0000

MikeBishop commented on this pull request.



> @@ -443,7 +444,7 @@ Google QUIC Demultipexing Bit:
 Reserved:
 
 : The sixth, seventh, and eighth bits (0x7) of octet 0 are reserved for

You've removed "octet 1" above, but still have "octet 0" here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1437#pullrequestreview-127659775

v2.28.0 | Report a Bug | By Email | System Status