Re: [quicwg/base-drafts] Clarify section on negotiating connection IDs (#3349)

Nick Banks <notifications@github.com> Wed, 15 January 2020 20:45 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BF2D81208EA for <quic-issues@ietfa.amsl.com>; Wed, 15 Jan 2020 12:45:23 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MYn-I6VlWbZR for <quic-issues@ietfa.amsl.com>; Wed, 15 Jan 2020 12:45:18 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 179F612089C for <quic-issues@ietf.org>; Wed, 15 Jan 2020 12:45:18 -0800 (PST)
Received: from github-lowworker-2ef7ba1.ac4-iad.github.net (github-lowworker-2ef7ba1.ac4-iad.github.net [10.52.16.66]) by smtp.github.com (Postfix) with ESMTP id 75A7FC61141 for <quic-issues@ietf.org>; Wed, 15 Jan 2020 12:45:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579121117; bh=vW3T/tQnzxY8UxcwL5eEOVZ7fFhCQaaDTrkhACP1bVQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mzxrpcZYvmXTmPy/jvcY4CWNfwr0oY1q/vIRfcoRdac6AMgT6nNM+3XYl8O+hkZcs ZuEiOxW9RjEOQqOQPBYqBSIDoVkQskyqFL6QchmykH3SU2j28cSjDcsUKlTcEP/XKO USDpHBIF+EDxxUngsnflbreZNRDsvNRVG/gw/NrY=
Date: Wed, 15 Jan 2020 12:45:17 -0800
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYUM3XYLZY33O3DJDF4FSWF3EVBNHHCBTP6UY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3349/review/343509112@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3349@github.com>
References: <quicwg/base-drafts/pull/3349@github.com>
Subject: Re: [quicwg/base-drafts] Clarify section on negotiating connection IDs (#3349)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e1f79dd66ef5_5383fdd572cd96c14714c"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/AW8WfQI9v669KiRy5m1iHsOryjI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jan 2020 20:45:24 -0000

nibanks commented on this pull request.



> +the SCID supplied by the server as the DCID for subsequent packets, including
+all subsequent 0-RTT packets. This means that a client might change the DCID

I think it might just be best to explicitly state which packet types require use of the new DCID. Not mentioning handshake packets here just leaves it unclear IMO.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3349#pullrequestreview-343509112