Re: [quicwg/base-drafts] QPACK [editorial] Update text to include both criteria of "blocking entry". (#2937)

afrind <notifications@github.com> Tue, 13 August 2019 21:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CB2CC1208E9 for <quic-issues@ietfa.amsl.com>; Tue, 13 Aug 2019 14:37:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YJG_5lN28umF for <quic-issues@ietfa.amsl.com>; Tue, 13 Aug 2019 14:37:18 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C64F01208E6 for <quic-issues@ietf.org>; Tue, 13 Aug 2019 14:37:18 -0700 (PDT)
Date: Tue, 13 Aug 2019 14:37:17 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1565732238; bh=rOAAnHYOGD3ehT+N4rstSk4qlRoS4ucjDgPr8uRVlww=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=jzS/6Oz4y6QWDrcl9JEJV1wMLrlW/PLchz0eMudLx5hK3y92R798yqlQGWo/QN6/n 0MweaBSVeRKGOZk7y5uPF7onRAXWJTeLawFFk2ZvGBJ1cccDqoi2hK8x3k1BI/s25c XdMwFgKax6zNDmsTzd9tGa6dbKVR+YG6b5QtWTmw=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZG342U5OM2EPCRAEV3MBQA3EVBNHHBYU23SE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2937/review/274569683@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2937@github.com>
References: <quicwg/base-drafts/pull/2937@github.com>
Subject: Re: [quicwg/base-drafts] QPACK [editorial] Update text to include both criteria of "blocking entry". (#2937)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d532d8df21bd_63e53f9985ecd96c5245b4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/AXaUEAgyZIIM2JwDJ6ndneP1e8w>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Aug 2019 21:37:21 -0000

afrind commented on this pull request.



> @@ -229,8 +229,9 @@ table that it will emit a reference for.  As new entries are inserted, the
 encoder increases the draining index to maintain the section of the table that
 it will not reference.  If the encoder does not create new references to entries
 with an absolute index lower than the draining index, the number of
-unacknowledged references to those entries will eventually become zero, allowing
-them to be evicted.
+unacknowledged references to every such entry will eventually become zero,
+allowing it to be evicted provided that its insertion has been acknowledged by
+the decoder.

This is now a pretty long sentence.  Maybe end it after 'become zero', and start a new sentence talking about eviction?

> @@ -359,9 +360,9 @@ infer from this instruction that any updates to the dynamic table have been
 received.
 
 The Header Acknowledgement and Stream Cancellation instructions permit the
-encoder to remove references to entries in the dynamic table.  When entries
-have zero references they are no longer considered blocking (see
-{{blocked-insertion}}).
+encoder to remove references to entries in the dynamic table.  When an entry
+with absolute index lower than the Known Received Count has zero references,

Does this leave ambiguous what happens to entries with absolute indices higher than Known Received Count?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2937#pullrequestreview-274569683