Re: [quicwg/base-drafts] MAX_PUSH_ID: lower-than-previous value conn error seems too severe (#2412)

Lucas Pardue <notifications@github.com> Tue, 05 February 2019 01:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AD9E5130F23 for <quic-issues@ietfa.amsl.com>; Mon, 4 Feb 2019 17:40:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.553
X-Spam-Level:
X-Spam-Status: No, score=-12.553 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fKz0BUzf9fRG for <quic-issues@ietfa.amsl.com>; Mon, 4 Feb 2019 17:40:27 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A037F12D4E7 for <quic-issues@ietf.org>; Mon, 4 Feb 2019 17:40:27 -0800 (PST)
Date: Mon, 04 Feb 2019 17:40:26 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549330826; bh=zYQQAxj6Dfi4K5HQkkIh5eyWERRReclNPiX0KWfqZTg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=p/q3htktEiP4EvpLdYS88jvi+S+8913oAqd6MGSVysTAYAIUWSaxyY1RgCuraOqmi pnFp1YO6qH38/4baO+44+P5O0CzQ2ieWXx39LffXPm1b6TqjHyvysT4wC5yL6ezUJ3 bm9pXxB/8gp19mcVhJ0/Q9M2MNuYwiG9DBO2KvXk=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abfd026d740c213955a9c99e420d4e84f50abbeed592cf000000011870ab8a92a169ce183b427c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2412/460482554@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2412@github.com>
References: <quicwg/base-drafts/issues/2412@github.com>
Subject: Re: [quicwg/base-drafts] MAX_PUSH_ID: lower-than-previous value conn error seems too severe (#2412)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c58e98a3a54a_18fa3ff8db8d45b434774"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/AcDmjUje3V-usYzTfJjawrROK00>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Feb 2019 01:40:30 -0000

So the hypothetical implementation I have in mind is a client that receives pushes that can be processed independently. In some edge cases, pushes may have mixed use of static and dynamic tables. Static-only pushes can make progress without reliance on QPACK stream(s) progressing. I might set up a handling chain for a single push that does something like "when complete, send MAX_PUSH_ID with value current push ID + 1". There may be cases where this leads to a lower limit being sent.

Another edge case is naive handling of CANCEL_PUSH when it is sent by the server. A client that wants to maintain a number of concurrent pushes needs to update MAX_PUSH_ID pretty quick, and a simple way to do this is to read the Push ID out of CANCEL_PUSH and increment by 1. Again this may cause a lower limit being sent.

One solution to these problems is, on the client side, to track the high water mark of Push ID and only emit a MAX_PUSH_ID frame that increases the high water mark. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2412#issuecomment-460482554