IETF Logo Mail Archive

Re: [quicwg/base-drafts] Don't retransmit lost packets that are acked later (#3957)

ianswett <notifications@github.com> Wed, 29 July 2020 00:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8B2F03A0D1A for <quic-issues@ietfa.amsl.com>; Tue, 28 Jul 2020 17:33:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1wdg_18skgMi for <quic-issues@ietfa.amsl.com>; Tue, 28 Jul 2020 17:33:16 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 97F003A0D18 for <quic-issues@ietf.org>; Tue, 28 Jul 2020 17:33:16 -0700 (PDT)
Received: from github-lowworker-f1f7af9.ash1-iad.github.net (github-lowworker-f1f7af9.ash1-iad.github.net [10.56.111.13]) by smtp.github.com (Postfix) with ESMTP id 7E5E2560DA0 for <quic-issues@ietf.org>; Tue, 28 Jul 2020 17:33:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595982795; bh=sm99jMr0AH46ZtKDyBYKApIWbPjMjreGUuCaAKtOLBk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=GWY9QCW2Ct9wWXzUMAkJmcjFyDkVCBU1bcqS6RQ5tQ/0hH6XXnm3BQUxzU1Z7iJL4 bJzSGXGmJY1K3bbD3R8UxxMaZwsya77QfQcsEXRnlUubVSPM3YpqfgydNuhiL6Qdux 85ps04L4ayDVEOYi+89+iiUVFT9Ee8bGIEffZPTg=
Date: Tue, 28 Jul 2020 17:33:15 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK53MP6R77ZZCHFP7RN5FSSMXEVBNHHCPIKQDU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3957/review/457117735@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3957@github.com>
References: <quicwg/base-drafts/pull/3957@github.com>
Subject: Re: [quicwg/base-drafts] Don't retransmit lost packets that are acked later (#3957)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f20c3cb6ef06_600b16f813868d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/AjdoxuwDaVdFrzN1I_u4bvZu6kE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jul 2020 00:33:19 -0000

@ianswett approved this pull request.

I think what you're saying is fine, but another attempt at an editorial suggstion.

> +acknowledged. This includes packets that are acknowledged after being declared
+lost, which can happen in the presence of network reordering. Doing so requires
+senders to retain information about packets after they are declared lost. A

```suggestion
acknowledged. This includes packets acknowledged after being
declared lost due to network reordering, which requires senders to
retain information about packets after they are declared lost. A
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3957#pullrequestreview-457117735

v2.23.0 | Report a Bug | By Email