IETF Logo Mail Archive

Re: [quicwg/base-drafts] Fix for #3835 (#4014)

Jana Iyengar <notifications@github.com> Wed, 19 August 2020 21:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C6FE83A0E6D for <quic-issues@ietfa.amsl.com>; Wed, 19 Aug 2020 14:51:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.009
X-Spam-Level:
X-Spam-Status: No, score=-2.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e85w04l617Fv for <quic-issues@ietfa.amsl.com>; Wed, 19 Aug 2020 14:51:49 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A050E3A0E6C for <quic-issues@ietf.org>; Wed, 19 Aug 2020 14:51:49 -0700 (PDT)
Received: from github-lowworker-cd7bc13.ac4-iad.github.net (github-lowworker-cd7bc13.ac4-iad.github.net [10.52.25.102]) by smtp.github.com (Postfix) with ESMTP id D7AD95E0F16 for <quic-issues@ietf.org>; Wed, 19 Aug 2020 14:51:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597873908; bh=V2+WJm29GnApATozot2GAxhdhuB0d+dKOXUizdLA7Ls=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DH2K/IVaBdNpwQXmS08sbaY/j2xp6dLvL1QuFdfMNiic9BfkfGbuflXzoqWWRaVTg hdXcE90C9ds0Q1m/tTcfq0SK+UY4BSnDWqLYf3U5ELDZAnlAUxDwxup/M2pt7nfo7l Z+VEgVdwAMM2kz4BXU2ZRkvi9y8l70HGelvqY5+M=
Date: Wed, 19 Aug 2020 14:51:48 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYHM3UJZ7KG3LJET355JF77JEVBNHHCRI7QOY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4014/review/470990530@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4014@github.com>
References: <quicwg/base-drafts/pull/4014@github.com>
Subject: Re: [quicwg/base-drafts] Fix for #3835 (#4014)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f3d9ef4c7dd6_2bc619642428c4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/AnOaeHw140FTrXTDoL8F2eOMZk0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Aug 2020 21:51:51 -0000

@janaiyengar requested changes on this pull request.

I don't see the point of this. The state transitions are currently only on things that move an endpoint out of that state. This transition is not one such.

I'll note that if this is to become an exhaustive FSM, that would be unreadable and not particularly useful.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4014#pullrequestreview-470990530

v2.23.0 | Report a Bug | By Email