Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH and allow duplicate PUSH_PROMISE (#3309)
ianswett <notifications@github.com> Fri, 20 December 2019 17:18 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DD18312084D for <quic-issues@ietfa.amsl.com>; Fri, 20 Dec 2019 09:18:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GWy8NJKMz_Gf for <quic-issues@ietfa.amsl.com>; Fri, 20 Dec 2019 09:18:41 -0800 (PST)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5F1581209FB for <quic-issues@ietf.org>; Fri, 20 Dec 2019 09:18:29 -0800 (PST)
Received: from github-lowworker-28f8021.ac4-iad.github.net (github-lowworker-28f8021.ac4-iad.github.net [10.52.25.98]) by smtp.github.com (Postfix) with ESMTP id B9728660C4D for <quic-issues@ietf.org>; Fri, 20 Dec 2019 09:18:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1576862308; bh=oeDiiApyUxXaoVZFo+D2Ch8foyvrBbst+VAchsolWpI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ta18k6Ym7b+PANjO+FAiAK7AmC7VSwaWPQcJHkUoimfLkTw3gtjkxOHFLITErJOo8 wh2e9SBJKBMxdN+QnRypyR/d+z9zC2n7+v3QCKB/R0ZBisbQqtStr4sT4ITn4fjV1m 16CbHtTCSRed8DT/PycxVPXd0QIGUQDHzqqsuZcQ=
Date: Fri, 20 Dec 2019 09:18:28 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYD6J5SZTNR5SFHQRV4BI2OJEVBNHHCAQAPGY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3309/review/335391434@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3309@github.com>
References: <quicwg/base-drafts/pull/3309@github.com>
Subject: Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH and allow duplicate PUSH_PROMISE (#3309)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dfd0264aa928_47a03fd9f06cd96415242e0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Arpv-xZ8BQFZsdOFrGGEVv7Aiv8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Dec 2019 17:18:43 -0000
ianswett approved this pull request. I think this LG, but certainly @MikeBishop should take a look > -become available, or can initiate requests for discovered resources and cancel -the requests if the requested resource is already being pushed. When a client -receives a new push stream with an as-yet-unknown Push ID, both the associated -client request and the pushed request headers are unknown. The client can -buffer the stream data in expectation of the matching PUSH_PROMISE. The client -can use stream flow control (see section 4.1 of {{QUIC-TRANSPORT}}) to limit the -amount of data a server may commit to the pushed stream. +Due to reordering, push stream data can arrive before the corresponding +PUSH_PROMISE frame. When a client receives a new push stream with an +as-yet-unknown Push ID, both the associated client request and the pushed +request headers are unknown. The client can buffer the stream data in +expectation of the matching PUSH_PROMISE. The client can use stream flow control +(see section 4.1 of {{QUIC-TRANSPORT}}) to limit the amount of data a server may +commit to the pushed stream. + +If the same Push ID is promised on multiple request streams, the decompressed I might be inclined to put this at the end of the paragraph on lines 623/624? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3309#pullrequestreview-335391434
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Lucas Pardue
- [quicwg/base-drafts] Remove DUPLICATE_PUSH and al… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… ianswett
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Lucas Pardue
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Lucas Pardue
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Kazuho Oku
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Kazuho Oku
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Kazuho Oku
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Lucas Pardue
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Lucas Pardue
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Lucas Pardue
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Kazuho Oku
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Jana Iyengar
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Lucas Pardue
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Ryan Hamilton
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop
- Re: [quicwg/base-drafts] Remove DUPLICATE_PUSH an… Mike Bishop