Re: [quicwg/base-drafts] Other congestion controllers (#1633)

Martin Thomson <notifications@github.com> Thu, 02 August 2018 23:09 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 61505130DF7 for <quic-issues@ietfa.amsl.com>; Thu, 2 Aug 2018 16:09:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zO5ibuw2jkRl for <quic-issues@ietfa.amsl.com>; Thu, 2 Aug 2018 16:09:03 -0700 (PDT)
Received: from out-12.smtp.github.com (out-12.smtp.github.com [192.30.254.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AB98B126CC7 for <quic-issues@ietf.org>; Thu, 2 Aug 2018 16:09:03 -0700 (PDT)
Date: Thu, 02 Aug 2018 16:09:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1533251342; bh=fNmgt4mU8wuW9WjPB4hilWXEqFluTzNHSJyWte4UcaM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Fpk7DdXfbrCwOsVXVMBb6tFVqdC2lvR7wufOpOM2uPbzOYumGYQUDpa1SjOAXvM8S 2i/IPERZxhWN06Xpefr4V77dwoPcU2bAkqZ3OcL7szSjwwfpfRc7pn5Sqw9a0ghi+R IOroqNtaP1PeXdV8tc2lRo8WicR04TPxEEUlKEo0=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4b7ec0f4f696323a5c01a1c1621bb86da209f08b92cf00000001177b510e92a169ce14b1ddfe@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1633/review/143008398@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1633@github.com>
References: <quicwg/base-drafts/pull/1633@github.com>
Subject: Re: [quicwg/base-drafts] Other congestion controllers (#1633)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b638f0e6cac3_4e883fc9f24d45bc9205"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/AwMO_HCU_Gn4GsRk9hHRDYMZJEk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Aug 2018 23:09:05 -0000

martinthomson approved this pull request.

Yeah, this is good.  Wondering if we need to say more, but I'll leave that to your discretion.

>  
 QUIC hosts MUST NOT send packets if they would increase bytes_in_flight
-(defined in {{vars-of-interest}}) beyond the available congestion window, unless
-the packet is a probe packet sent after the TLP or RTO timer expires, as
-described in {{tlp}} and {{rto}}.
+(defined in {{vars-of-interest}}) beyond the available congestion window,
+unless the packet is a probe packet sent after the TLP or RTO timer expires,
+as described in {{tlp}} and {{rto}}.
+
+Implementations MAY use other congestion control algorithms.

Do we also need to say that endpoints don't need to use the same congestion controller?  IOW, "Implementations MAY use a different congestion control algorithm, even within the same connection.  The signals that QUIC provides for congestion control are generic and can support different congestion control regimens."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1633#pullrequestreview-143008398