Re: [quicwg/base-drafts] Add Advice and Rules for CONN_CLOSE in Initial and Handshake (#1786)

martinduke <> Thu, 27 September 2018 20:32 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id AEA74130F43 for <>; Thu, 27 Sep 2018 13:32:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -8.455
X-Spam-Status: No, score=-8.455 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id jgqXYFC_Vo74 for <>; Thu, 27 Sep 2018 13:32:04 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 94544130E4B for <>; Thu, 27 Sep 2018 13:32:04 -0700 (PDT)
Date: Thu, 27 Sep 2018 13:32:01 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1538080324; bh=VefD5hVlIqShoDk12BLVe7VlGDRO0Fs+Y8ZeXEcdQLQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=I+s5JEaibCbFEIZC8+rfBicGfwz572a+Ch6QIeCJSnzFfmJXbYTbiDhGgo89KdYU9 C1eMGBWEnP1GdMCuUkbhXdlj67fqPis/La7q1hsefUdFSjSPz6JQoJ+ExcUbifBK7E YPJcUZalwrlWcurnoZlI/0BIvivlikgYEzQSbw1U=
From: martinduke <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/issues/1786/>
In-Reply-To: <quicwg/base-drafts/issues/>
References: <quicwg/base-drafts/issues/>
Subject: Re: [quicwg/base-drafts] Add Advice and Rules for CONN_CLOSE in Initial and Handshake (#1786)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bad3e41c39b2_53ac3f979a4d45c419933d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Thu, 27 Sep 2018 20:32:07 -0000

I would recommend the following changes.

1) Update Sec 4.1.1 of the TLS draft (@mikkelfj 's find above) to allow quietly dropping the packet when CRYPTO overruns.
2) Silently drop packets with CONN_CLOSE if we have received a higher encryption level from the peer.
3) When closing the connection, send CONNECTION_CLOSE with the latest keys you have. If you haven't received a packet with those keys yet, also send with the previous keys.

If people are comfortable with that, I'll file a PR.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: