Date: Mon, 09 Dec 2019 20:03:54 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK3CUVVKQ3VUR4MS63V37RF2VEVBNHHB7MNOEU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3281/review/329578488@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3281@github.com>
References: <quicwg/base-drafts/pull/3281@github.com>
Subject: Re: [quicwg/base-drafts] NEW_TOKEN contains globally unique values
 (#3281)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5def192a1b39a_bba3fdde78cd96c1241d2";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BARlkOvOWdXcbwuoIC8ikYDHmVY>


----==_mimepart_5def192a1b39a_bba3fdde78cd96c1241d2
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

martinthomson commented on this pull request.



> @@ -1719,9 +1719,11 @@ encrypted form in the token.
 A token issued with NEW_TOKEN MUST NOT include information that would allow
 values to be linked by an on-path observer to the connection on which it was
 issued, unless the values are encrypted.  For example, it cannot include the
-previous connection ID or addressing information.  Information that allows the
-server to distinguish between tokens from Retry and NEW_TOKEN MAY be accessible
-to entities other than the server.
+previous connection ID or addressing information.  Each NEW_TOKEN frame MUST
+be unique among all connections to that server, unless the frame is sent to

No, there is no obligation to check.  Do you think that we need to say as much?

The client should only see duplicates if there is a spurious loss detected by the server.

I like your suggested text and will use that.  The duplicate detection is already described on [line 5073](https://github.com/quicwg/base-drafts/pull/3281/files#diff-db016291106766877c4921a79f8596e0R5073).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3281#discussion_r355835144
----==_mimepart_5def192a1b39a_bba3fdde78cd96c1241d2
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@martinthomson</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3281#discussion_r355835144">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1719,9 +1719,11 @@ encrypted form in the token.
 A token issued with NEW_TOKEN MUST NOT include information that would allow
 values to be linked by an on-path observer to the connection on which it was
 issued, unless the values are encrypted.  For example, it cannot include the
-previous connection ID or addressing information.  Information that allows the
-server to distinguish between tokens from Retry and NEW_TOKEN MAY be accessible
-to entities other than the server.
+previous connection ID or addressing information.  Each NEW_TOKEN frame MUST
+be unique among all connections to that server, unless the frame is sent to
</pre>
<p>No, there is no obligation to check.  Do you think that we need to say as much?</p>
<p>The client should only see duplicates if there is a spurious loss detected by the server.</p>
<p>I like your suggested text and will use that.  The duplicate detection is already described on <a href="https://github.com/quicwg/base-drafts/pull/3281/files#diff-db016291106766877c4921a79f8596e0R5073">line 5073</a>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3281?email_source=notifications&amp;email_token=AFTOJKZLJJGEW4HZGHTDGALQX4IKVA5CNFSM4JUSKXZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOSPP6A#discussion_r355835144">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK5BHFHCHL4G7PUMU5DQX4IKVANCNFSM4JUSKXZA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK2DAS4PHYTFTXBUAYDQX4IKVA5CNFSM4JUSKXZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOSPP6A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3281?email_source=notifications\u0026email_token=AFTOJKZLJJGEW4HZGHTDGALQX4IKVA5CNFSM4JUSKXZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOSPP6A#discussion_r355835144",
"url": "https://github.com/quicwg/base-drafts/pull/3281?email_source=notifications\u0026email_token=AFTOJKZLJJGEW4HZGHTDGALQX4IKVA5CNFSM4JUSKXZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOSPP6A#discussion_r355835144",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5def192a1b39a_bba3fdde78cd96c1241d2--