Re: [quicwg/base-drafts] Don't request control streams be closed (#2666)

Jana Iyengar <notifications@github.com> Mon, 06 May 2019 23:45 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D105512006B for <quic-issues@ietfa.amsl.com>; Mon, 6 May 2019 16:45:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nQbivHbMI2yh for <quic-issues@ietfa.amsl.com>; Mon, 6 May 2019 16:45:36 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B947B12001E for <quic-issues@ietf.org>; Mon, 6 May 2019 16:45:36 -0700 (PDT)
Date: Mon, 06 May 2019 16:45:35 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557186335; bh=cm/iseltf7npnQbf+TJ+PvYq4+7z1ALuo1BpeLCyeGs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=asX1x05am3gaFlBIXkGL03afIZnPeJRDgqHST0fI4K6U18xTROZSJu254a54IgENj TkMBuMSrITlRQcAxGAXuUgkfvHUOyGo9mWjmhC5FmXLZA7c1WFOGnozdvLpG10Jnbz MjNOA3WCjK2SRfhqC5uQHEJrXntKwRyQgv3J4iq4=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK43GVN35RJZXP2FXS523X4Z7EVBNHHBUPKWSM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2666/review/234251167@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2666@github.com>
References: <quicwg/base-drafts/pull/2666@github.com>
Subject: Re: [quicwg/base-drafts] Don't request control streams be closed (#2666)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd0c71fdfc7b_703b3fc844acd964192167"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BDWT48eInLPtvjoKE-0m78ct1Y0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 May 2019 23:45:39 -0000

janaiyengar approved this pull request.

nits, but LGTM

> @@ -359,9 +359,10 @@ the first frame of the control stream is any other frame type, this MUST be
 treated as a connection error of type HTTP_MISSING_SETTINGS. Only one control
 stream per peer is permitted; receipt of a second stream which claims to be a
 control stream MUST be treated as a connection error of type
-HTTP_WRONG_STREAM_COUNT.  The sender MUST NOT close the control stream.  If the
-control stream is closed at any point, this MUST be treated as a connection
-error of type HTTP_CLOSED_CRITICAL_STREAM.
+HTTP_WRONG_STREAM_COUNT.  The sender MUST NOT close the control stream, and the
+receiver MUST NOT request that the sender close the stream.  If the control

```suggestion
receiver MUST NOT request that the sender close the control stream.  If the control
```

> @@ -359,9 +359,10 @@ the first frame of the control stream is any other frame type, this MUST be
 treated as a connection error of type HTTP_MISSING_SETTINGS. Only one control
 stream per peer is permitted; receipt of a second stream which claims to be a
 control stream MUST be treated as a connection error of type
-HTTP_WRONG_STREAM_COUNT.  The sender MUST NOT close the control stream.  If the
-control stream is closed at any point, this MUST be treated as a connection
-error of type HTTP_CLOSED_CRITICAL_STREAM.
+HTTP_WRONG_STREAM_COUNT.  The sender MUST NOT close the control stream, and the
+receiver MUST NOT request that the sender close the stream.  If the control
+stream is closed at any point, this MUST be treated as a connection error of

```suggestion
stream is closed at any point by either end, this MUST be treated as a connection error of
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2666#pullrequestreview-234251167