Date: Fri, 14 Sep 2018 04:36:25 -0700
From: Magnus Westerlund <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab42ef29d9a80836e414be79a6b75838a2ed5df13292cf0000000117b35f3992a169ce152ea636@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1715/c421331903@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1715@github.com>
References: <quicwg/base-drafts/pull/1715@github.com>
Subject: Re: [quicwg/base-drafts] Add max_bytes_before_ack to transport (#1715)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5b9b9d395b7ba_1393fd7b00d45b820773";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BDy1Qrk3ko2-1bUwVKeq4Slko8k>


----==_mimepart_5b9b9d395b7ba_1393fd7b00d45b820773
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

I think the first issue is that currently TPs are only negotiated at connection establishment. Which, makes it impossible to change them if one change MTUs due to PLPMTUD or a client side migration. 

I also agree that adding clarified recommendations on delayed ACK. I think one full RTT is a bit much delay when one have something to ACK. I am not certain I understand the full relation and precedens of the minimal, maximum etc. Here I think one should be careful to write up rules and analys their impact and what will happen in the various cases, with both really low RTTs (Backplane/loopback), as well as LANs and long fat pipes. In Kista we discussed that 1/4 of an RTT likely makes sense as an upper limit for sender stacks that accept delayed ACKs. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1715#issuecomment-421331903
----==_mimepart_5b9b9d395b7ba_1393fd7b00d45b820773
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p>I think the first issue is that currently TPs are only negotiated at c=
onnection establishment. Which, makes it impossible to change them if one=
 change MTUs due to PLPMTUD or a client side migration.</p>
<p>I also agree that adding clarified recommendations on delayed ACK. I t=
hink one full RTT is a bit much delay when one have something to ACK. I a=
m not certain I understand the full relation and precedens of the minimal=
, maximum etc. Here I think one should be careful to write up rules and a=
nalys their impact and what will happen in the various cases, with both r=
eally low RTTs (Backplane/loopback), as well as LANs and long fat pipes. =
In Kista we discussed that 1/4 of an RTT likely makes sense as an upper l=
imit for sender stacks that accept delayed ACKs.</p>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/1715#issuecomment-421331903">view it on GitHub</a>, o=
r <a href=3D"https://github.com/notifications/unsubscribe-auth/AWbkqxP9Yv=
eoQlb7u952OJWXcTwTgfSLks5ua5S5gaJpZM4WSkod">mute the thread</a>.<img src=3D=
"https://github.com/notifications/beacon/AWbkq-2d7ZDCNPL-rlcCroUnUIfENVBq=
ks5ua5S5gaJpZM4WSkod.gif" height=3D"1" width=3D"1" alt=3D"" /></p>
<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_versio=
n":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name"=
:"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"=
quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"http=
s://assets-cdn.github.com/images/email/message_cards/header.png","avatar_=
image_url":"https://assets-cdn.github.com/images/email/message_cards/avat=
ar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicw=
g/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gloi=
nul in #1715: I think the first issue is that currently TPs are only nego=
tiated at connection establishment. Which, makes it impossible to change =
them if one change MTUs due to PLPMTUD or a client side migration. \r\n\r=
\nI also agree that adding clarified recommendations on delayed ACK. I th=
ink one full RTT is a bit much delay when one have something to ACK. I am=
 not certain I understand the full relation and precedens of the minimal,=
 maximum etc. Here I think one should be careful to write up rules and an=
alys their impact and what will happen in the various cases, with both re=
ally low RTTs (Backplane/loopback), as well as LANs and long fat pipes. I=
n Kista we discussed that 1/4 of an RTT likely makes sense as an upper li=
mit for sender stacks that accept delayed ACKs. "}],"action":{"name":"Vie=
w Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1715#is=
suecomment-421331903"}}}</script>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/1715#issuecomment-4=
21331903",
"url": "https://github.com/quicwg/base-drafts/pull/1715#issuecomment-4213=
31903",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [quicwg/base-drafts] Add max_bytes_before_ack to transport =
(#1715)",
"sections": [
{
"text": "",
"activityTitle": "**Magnus Westerlund**",
"activityImage": "https://assets-cdn.github.com/images/email/message_card=
s/avatar.png",
"activitySubtitle": "@gloinul",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \=
"quicwg/base-drafts\",\n\"issueId\": 1715,\n\"IssueComment\": \"{{IssueCo=
mment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\=
": \"quicwg/base-drafts\",\n\"pullRequestId\": 1715\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1715#issuecomment-4213=
31903"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 3739673=
89\n}"
}
],
"themeColor": "26292E"
}
]</script>=

----==_mimepart_5b9b9d395b7ba_1393fd7b00d45b820773--