IETF Logo Mail Archive

Re: [quicwg/base-drafts] enforce the active_connection_id_limit (#3201)

Marten Seemann <notifications@github.com> Mon, 18 November 2019 08:00 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BB6991208E8 for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 00:00:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ceKAuCHilwdn for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 00:00:08 -0800 (PST)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1B5C81200B2 for <quic-issues@ietf.org>; Mon, 18 Nov 2019 00:00:08 -0800 (PST)
Received: from github-lowworker-5fb2734.va3-iad.github.net (github-lowworker-5fb2734.va3-iad.github.net [10.48.19.27]) by smtp.github.com (Postfix) with ESMTP id C4D38A0840 for <quic-issues@ietf.org>; Mon, 18 Nov 2019 00:00:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1574064006; bh=j79eR4fynCF/NJ3c+9FxUHW04A5qqtPmdg/Mtdb4Uw4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=fLW6JJq2LJ3+8DwDmhJsFEI9cGd2Ia34GR4+EwzWaGMgl/HvfT76PbIdQt3QQQ4sH wEqpU6zNffqI6ncBf8X9IYUq0GSTASFh0uS9sFuFr2e9VzHHEjzKXze9tRUM3VucLO 1Nh/fF/24N7QihhiZBqNH7/3s9g4OiyXg2dp28g0=
Date: Mon, 18 Nov 2019 00:00:06 -0800
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK33RXWCJ5Y6WKKMEN5336BANEVBNHHB532IFY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3201/review/318148765@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3201@github.com>
References: <quicwg/base-drafts/pull/3201@github.com>
Subject: Re: [quicwg/base-drafts] enforce the active_connection_id_limit (#3201)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd24f86b5e2f_5fc63fb7e1ccd96c28226f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BQnf8Ls3KPm1qdKpUrSxXylvmIM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Nov 2019 08:00:10 -0000

marten-seemann commented on this pull request.



> @@ -4590,8 +4595,11 @@ preferred_address (0x000d):
 active_connection_id_limit (0x000e):
 
 : The maximum number of connection IDs from the peer that an endpoint is willing
-  to store. This value includes only connection IDs sent in NEW_CONNECTION_ID
-  frames. If this parameter is absent, a default of 0 is assumed.
+  to store. This value includes connection IDs sent in NEW_CONNECTION_ID frames,
+  the connection ID used during the handshake as well as the connection ID
+  provided in the preferred_address transport parameter.
+  If the active_connection_id_limit parameter is absent, a default of 2 is
+  assumed. Values below 2 are invalid.

Thanks for catching this. I updated the PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3201#discussion_r347238838

v2.23.0 | Report a Bug | By Email