Re: [quicwg/base-drafts] Remove UNSOLICITED_PATH_RESPONSE (#1539)

ianswett <notifications@github.com> Mon, 09 July 2018 13:35 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CE1AE130FC1 for <quic-issues@ietfa.amsl.com>; Mon, 9 Jul 2018 06:35:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.11
X-Spam-Level:
X-Spam-Status: No, score=-6.11 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FE_vq_7ECQsK for <quic-issues@ietfa.amsl.com>; Mon, 9 Jul 2018 06:35:36 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3CB0812DD85 for <quic-issues@ietf.org>; Mon, 9 Jul 2018 06:35:36 -0700 (PDT)
Date: Mon, 09 Jul 2018 06:35:35 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531143335; bh=yxLIqgPAYpNFJkUCErNgxEQcrHAvT0J+MIhhVmzqiVo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FdQp0XRmFcwqQqXcfglonQjoRt6ErKAYxtlpXC96BD9NqQmlW7kMIg42+s15dOMm8 3E/wVRQlGZS/wDXPirRy/eVOvo5PHdTFQYmaM+NS1qmMnvpaS7ADKUNsp2yaxbvlUQ j/USe5V/O6JhazmPVvVOd6THRZcxKD+RKmYgqbl0=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab18567d6c9f264dae8aa32b2f701eaa7a0f11922592cf00000001175b26a792a169ce143ab128@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1539/review/135418690@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1539@github.com>
References: <quicwg/base-drafts/pull/1539@github.com>
Subject: Re: [quicwg/base-drafts] Remove UNSOLICITED_PATH_RESPONSE (#1539)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4364a738b93_44f22ac0932ecf60669a8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BRF0CSmkwmH0hCPGYH47yN3Hbms>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jul 2018 13:35:38 -0000

ianswett commented on this pull request.



> @@ -3293,7 +3293,7 @@ frame.  Its format is identical to the PATH_CHALLENGE frame
 
 If the content of a PATH_RESPONSE frame does not match the content of a
 PATH_CHALLENGE frame previously sent by the endpoint, the endpoint MAY generate
-a connection error of type UNSOLICITED_PATH_RESPONSE.
+a connection error of type PROTOCOL_VIOLATION.

Should this specify the frame type as PATH_RESPONSE now that frame type is present in CONNECTION_CLOSE?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1539#pullrequestreview-135418690