[quicwg/base-drafts] ACK_ECN type value is not incremented (#1520)

Daiki AMINAKA <notifications@github.com> Wed, 04 July 2018 08:05 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 52CDE130EDF for <quic-issues@ietfa.amsl.com>; Wed, 4 Jul 2018 01:05:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qnAriMP4Pzm4 for <quic-issues@ietfa.amsl.com>; Wed, 4 Jul 2018 01:05:36 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9DCDC130F0E for <quic-issues@ietf.org>; Wed, 4 Jul 2018 01:05:36 -0700 (PDT)
Date: Wed, 04 Jul 2018 01:05:35 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530691535; bh=wNT9ixVjgKoY+cJ511czCFXZ6jU4KRhh8m2NXar/W5c=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=uaFQfDx6zl40rZMcHK91r2pjDwHu60cfDYSXskfmy4UtfASU8Tz90lqLsQWSkE2a4 /oZzj6BXSpowN+cYufkkyPACc7/Z1Qdam3NSAUwQjZFjlfJTkFQA/MemZwkWBy5KmF vQILX0EXW7/ahKf46FSSmMS9QCb5oC1KCzj+crzg=
From: Daiki AMINAKA <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab581bdc37f1a7a87bd00d40d640503f8929e526e192cf00000001175441cf92a169ce14281420@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1520@github.com>
Subject: [quicwg/base-drafts] ACK_ECN type value is not incremented (#1520)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b3c7fcfa7dae_57942acfee8ccf605648d5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ami-GS
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BRy1HqGZ63-8UFMMNzYjtE5f4Pw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jul 2018 08:05:45 -0000

ACK_ECN type should be 0x1a if you expect the type to be incremented by 1. Or is this(0x20) expected value?

You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/1520

-- Commit Summary --

  * ACK_ECN type value is not incremented

-- File Changes --

    M draft-ietf-quic-transport.md (4)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/1520.patch
https://github.com/quicwg/base-drafts/pull/1520.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1520