Re: [quicwg/base-drafts] SetLossDetectionTime negative timeout (#2052)
ianswett <notifications@github.com> Wed, 28 November 2018 21:37 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A6DB613106D for <quic-issues@ietfa.amsl.com>; Wed, 28 Nov 2018 13:37:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GU_gUgUbOmUf for <quic-issues@ietfa.amsl.com>; Wed, 28 Nov 2018 13:37:02 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 864C4131069 for <quic-issues@ietf.org>; Wed, 28 Nov 2018 13:37:02 -0800 (PST)
Date: Wed, 28 Nov 2018 13:37:01 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543441021; bh=yQXkEShUa5exO767o/m/ufnIxgC1ICl4f+VsJqpd2eE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=YcdlcStylv/5CGI6VaAeaf4XSs2XqR4mjRAYHniM3Nn+BmzT++y4ng2UdzlXJM6lG FKWjOVPqxe52bcVasnT3abxCdR9boCA7slrRFKS+MSTujcRTE61HVYnt9WoIdn5eu8 RkYCaph8yXR62Br7P4q3aaIx9oXoh1zpeHKmLKhQ=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd8a90a61564896c8c73afd17e6a90dfccafafba992cf000000011816cc7d92a169ce16e756f7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2052/442613732@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2052@github.com>
References: <quicwg/base-drafts/issues/2052@github.com>
Subject: Re: [quicwg/base-drafts] SetLossDetectionTime negative timeout (#2052)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bff0a7dac4a3_625a3f95618d45c465982"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/BSAiEWFN2Cuy-FLOtbUA6CY_lRg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Nov 2018 21:37:11 -0000
@martinthomson if the timeout is unsigned, then max(0, timeout) doesn't help because timeout has already wrapped :( @kazuho Interesting example I've never considered. However, that doesn't cause an int underflow, just for the timer to be set in the past. I sent out a PR to avoid the int underflow, because it's easy to fix and I agree it's best to avoid negative values when possible. I'd rather not do anything to prevent timers being set in the past, because it can happen almost anywhere under some circumstances(ie: late alarms). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/2052#issuecomment-442613732
- [quicwg/base-drafts] SetLossDetectionTime negativ… Lars Eggert
- Re: [quicwg/base-drafts] SetLossDetectionTime neg… janaiyengar
- Re: [quicwg/base-drafts] SetLossDetectionTime neg… Lars Eggert
- Re: [quicwg/base-drafts] SetLossDetectionTime neg… ianswett
- Re: [quicwg/base-drafts] SetLossDetectionTime neg… Kazuho Oku
- Re: [quicwg/base-drafts] SetLossDetectionTime neg… Martin Thomson
- Re: [quicwg/base-drafts] SetLossDetectionTime neg… Kazuho Oku
- Re: [quicwg/base-drafts] SetLossDetectionTime neg… ianswett
- Re: [quicwg/base-drafts] SetLossDetectionTime neg… ianswett